-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] media player is not re-sizing to width of browser #676
Comments
Min height and width of player set during previous work; these changes may be triggering this issue. |
I was not able to reproduce this issue for Chrome on both my machine and BrowserStack for desktop. The browser wouldn't let me reduce the width to be less than the width of the bootstrap column containing the player. |
@Dananji Chrome and Safari on desktop is working fine for me now for both issues reported above, but the video player is still overflowing the page horizontally in Safari on iPhone in Browserstack. |
@elynema Latest changes from the Ramp build were not deployed properly in |
Tested and working fine on Chrome and Safari on desktop @Dananji Two issues:
|
The change for Android is included in the latest build of Ramp in Avalon, but the assets didn't compile and deploy in I will look into the zoom issue in iPhone. |
We set a minimum width to the player in iOS and Android devices to I can reduce this width to a lower value (~320px). Reducing it all the way to fit device width will result in the same issue we've seen before, where some of the player controls gets hidden. @elynema What do you think about reducing the minimum width of the player just enough to contain all the player controls? This value is around |
@Dananji I thought moving the progress bar up above was to allow us to zoom up to 200%? If we set a min width, then users might not be able to actually see the full content that's playing if they are zoomed, right? |
No ability to identify zoom level in the browser within JS is also a difficulty with some of these methods. |
Width is looking ok on Android, now. Stick with our current solution for 200% Zoom, which was developed as #596. Jon will create a new issue to investigate if we can develop a solution more like Vimeo, where controls are migrated into a joint panel behind a single config button when zoom goes up. |
Description
For both audio and video items, the media player is not re-sizing to the width of the browser on the playlist page. This requires the user to scroll the browser horizontally in order to access all the widgets. So far, this has been observed in Safari on iPhone as well as Chrome on desktop (when the browser is resized down). This is happening even when the browser is not zoomed at all and is happening for both audio and video on both playlist and media item pages.
Done Looks Like
The text was updated successfully, but these errors were encountered: