Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrubbing doesn't work in native player on demo site #516

Closed
1 task done
elynema opened this issue Jun 7, 2024 · 4 comments
Closed
1 task done

Scrubbing doesn't work in native player on demo site #516

elynema opened this issue Jun 7, 2024 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@elynema
Copy link

elynema commented Jun 7, 2024

Description

When testing the demo site in the iOS native player, scrubbing using the progress bar and the forward / backward 10 seconds buttons is not working at all. When the progress bar is dragged, the bar moves, but the video doesn't actually advance. When you click the forward / backward 10 seconds buttons, nothing happens to the video; it just continues playing.

I tested this in iPhone in Browserstack iOS 17 on the Ramp demo site, as well as iOS 16 on my local device. Scrubbing in the native player is working on mco-staging and on avalon-dev, so this must have been recently introduced in a Ramp change.

Could this be related to fixes for the slow scrubbing in #494?

Example from iOS 17 on Ramp demo site

Jun-11-2024 10-14-03

Done Looks Like

  • Seeking and scrubbing is functional in iOS the native player
@joncameron joncameron added the bug 🐛 Something isn't working label Jun 11, 2024
@joncameron
Copy link
Contributor

Odd rendering of VTT as well—text is left-aligned with an unexpected background color. Is this related to the same problem? If not we can create a new ticket to fix.

@Dananji Dananji self-assigned this Jun 20, 2024
@Dananji Dananji mentioned this issue Jun 20, 2024
@elynema
Copy link
Author

elynema commented Jun 25, 2024

Scrubbing does now seem to be working in the native player on the demo site. It is no longer working on avalon-dev, so leaving this here to finish QA once this Ramp build is pulled into Avalon.

@elynema
Copy link
Author

elynema commented Jun 28, 2024

@charumitraravi Can you QA this?

@charumitraravi
Copy link
Collaborator

QA completed. Scrubber is working as expected on the native player

@elynema elynema closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants