You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Looks the the SRT transcript for the demo page is being parsed incorrectly resulting in a hung page. This appears to be a regression beginning in 9f24f0e which fixed #476.
Click on the Transcript tab and from the dropdown choose "SRT Transcript"
Browser window becomes unresponsive.
Expected behavior
For the browser to not be bricked, even if there was an error.
Screenshots
This is not some browser bug. I've tested Chrome, Firefox, and Safari on my MBP. I'm confident you'd get similar behavior on any platform. The issue is present on your live demo site as well as locally after running yarn demo on the most recent commit (56c0bc4) to the main branch.
Additional context
Before using the transcript dropdown the following error can be observed in DevTools:
Text Track parsing errors for https://iiif-react-media-player.netlify.app/lunchroom_manners/lunchroom_manners.srt
video.es.js:222
VIDEOJS: ERROR: a
code: 0
message: "Malformed WebVTT signature."
name: "ParsingError"
[[Prototype]]: Error
constructor: ƒ a(e,t)
[[Prototype]]: Object
(anonymous) @ video.es.js:222
Setting a breakpoint on video.es.js:222 allowed me to inspect a more meaningful error a few stack frames up:
QA Notes from Charu about SRT crashing: (see #467 (comment))
When I try to access an item that only has an SRT transcript (for example, this page), the webpage crashes.
If a media item has multiple transcripts available and one of them is an SRT file, the page also crashes when I select the SRT transcript from the list (as seen in this example).
(refer the screenshots attached)
The text was updated successfully, but these errors were encountered:
patrick-lienau
changed the title
Selecting SRT transcript on demo page crashes browser tab.
Selecting SRT transcript on demo page crashes browser tab
May 1, 2024
Describe the bug
Looks the the SRT transcript for the demo page is being parsed incorrectly resulting in a hung page. This appears to be a regression beginning in 9f24f0e which fixed #476.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
For the browser to not be bricked, even if there was an error.
Screenshots
This is not some browser bug. I've tested Chrome, Firefox, and Safari on my MBP. I'm confident you'd get similar behavior on any platform. The issue is present on your live demo site as well as locally after running
yarn demo
on the most recent commit (56c0bc4) to themain
branch.Additional context
Before using the transcript dropdown the following error can be observed in DevTools:
Setting a breakpoint on
video.es.js:222
allowed me to inspect a more meaningful error a few stack frames up:QA Notes from Charu about SRT crashing: (see #467 (comment))
When I try to access an item that only has an SRT transcript (for example, this page), the webpage crashes.
If a media item has multiple transcripts available and one of them is an SRT file, the page also crashes when I select the SRT transcript from the list (as seen in this example).
(refer the screenshots attached)
The text was updated successfully, but these errors were encountered: