Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting SRT transcript on demo page crashes browser tab #489

Closed
patrick-lienau opened this issue May 1, 2024 · 1 comment
Closed

Selecting SRT transcript on demo page crashes browser tab #489

patrick-lienau opened this issue May 1, 2024 · 1 comment
Assignees

Comments

@patrick-lienau
Copy link
Collaborator

patrick-lienau commented May 1, 2024

Describe the bug
Looks the the SRT transcript for the demo page is being parsed incorrectly resulting in a hung page. This appears to be a regression beginning in 9f24f0e which fixed #476.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://iiif-react-media-player.netlify.app/
  2. Click on the Transcript tab and from the dropdown choose "SRT Transcript"
    image
  3. Browser window becomes unresponsive.

Expected behavior
For the browser to not be bricked, even if there was an error.

Screenshots
image

This is not some browser bug. I've tested Chrome, Firefox, and Safari on my MBP. I'm confident you'd get similar behavior on any platform. The issue is present on your live demo site as well as locally after running yarn demo on the most recent commit (56c0bc4) to the main branch.

Additional context
Before using the transcript dropdown the following error can be observed in DevTools:

Text Track parsing errors for https://iiif-react-media-player.netlify.app/lunchroom_manners/lunchroom_manners.srt
video.es.js:222

VIDEOJS: ERROR: a
  code: 0
  message: "Malformed WebVTT signature."
  name: "ParsingError"
    [[Prototype]]: Error
      constructor: ƒ a(e,t)
      [[Prototype]]: Object
      
(anonymous) @ video.es.js:222

Setting a breakpoint on video.es.js:222 allowed me to inspect a more meaningful error a few stack frames up:
image

QA Notes from Charu about SRT crashing: (see #467 (comment))

  1. When I try to access an item that only has an SRT transcript (for example, this page), the webpage crashes.

  2. If a media item has multiple transcripts available and one of them is an SRT file, the page also crashes when I select the SRT transcript from the list (as seen in this example).
    (refer the screenshots attached)

Screenshot 2024-05-16 at 7 45 08 PM Screenshot 2024-05-16 at 7 47 59 PM
@patrick-lienau patrick-lienau changed the title Selecting SRT transcript on demo page crashes browser tab. Selecting SRT transcript on demo page crashes browser tab May 1, 2024
@Dananji Dananji self-assigned this May 28, 2024
@joncameron
Copy link
Contributor

No longer crashing upon selection of SRT file in the Transcript component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants