Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rollup build with dynamic imports using code-splitting #254

Closed
1 task
Dananji opened this issue Oct 3, 2023 · 2 comments · Fixed by #297
Closed
1 task

Fix Rollup build with dynamic imports using code-splitting #254

Dananji opened this issue Oct 3, 2023 · 2 comments · Fixed by #297
Assignees
Labels
bug 🐛 Something isn't working dependencies Pull requests that update a dependency file release Features and bug fixes to be completed for next stable release

Comments

@Dananji
Copy link
Collaborator

Dananji commented Oct 3, 2023

Description

Ramp uses dynamic imports to load the relevant language maps from VideoJS for selected language within the component. This code breaks the rollup bundling process.

Done Looks Like

  • Rollup successfully bundles the library with dynamic imports

Notes

Possible solutions investigated;

Resources;

@Dananji Dananji added bug 🐛 Something isn't working dependencies Pull requests that update a dependency file release Features and bug fixes to be completed for next stable release labels Oct 3, 2023
@Dananji Dananji changed the title Rollup build fix with dynamic imports Fix Rollup build with dynamic imports using code-splitting Oct 3, 2023
@elynema
Copy link

elynema commented Nov 20, 2023

This is required if we want internationalization in Ramp for 7.7 release. If not, then we could leave this.

@elynema
Copy link

elynema commented Dec 1, 2023

@cjcolvar @Dananji I'm not sure there is any way for Jon or I to QA this. I think if it is working properly for you, we should just close this issue?

@elynema elynema closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dependencies Pull requests that update a dependency file release Features and bug fixes to be completed for next stable release
Projects
None yet
3 participants