Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto-advance Component #214

Closed
3 tasks done
joncameron opened this issue Aug 10, 2023 · 5 comments · Fixed by #242
Closed
3 tasks done

Add Auto-advance Component #214

joncameron opened this issue Aug 10, 2023 · 5 comments · Fixed by #242
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Aug 10, 2023

Description

From a code perspective it makes sense to have the auto-advance toggle to be a part of Ramp, since the state machine for this is on the Ramp side. It's easier to hook this up to the player state within Ramp rather than via Avalon.

Done Looks Like

  • An auto-advance toggle component for Ramp is added
  • Can be a part of structured navigation in the UI
  • Auto-advance behavior depends on the state of the toggle
@joncameron
Copy link
Contributor Author

One downside of being part of the structural metadata component is that it can't be put elsewhere on the page.

@elynema
Copy link

elynema commented Sep 5, 2023

This is in Ramp code only at this point; not merged into Avalon.

@cjcolvar
Copy link
Member

cjcolvar commented Sep 5, 2023

The auto-advance toggle button is on the ramp demo page but it doesn't seem to be working. Autoplay happens even when the toggle is switched off. I'm testing with this manifest: https://avalon-dev.dlib.indiana.edu/playlists/32/manifest.json

@elynema
Copy link

elynema commented Oct 5, 2023

Auto-play component is working as expected on the Ramp demo page. @cjcolvar Is the auto-play toggle an independent Ramp component, or is it part of the structured navigation component?

@elynema elynema closed this as completed Oct 5, 2023
@cjcolvar
Copy link
Member

cjcolvar commented Oct 6, 2023

@elynema It is an independent component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants