Skip to content
This repository has been archived by the owner on Nov 13, 2020. It is now read-only.

Loads remote images in Markdown #9

Closed
fregante opened this issue May 17, 2020 · 4 comments
Closed

Loads remote images in Markdown #9

fregante opened this issue May 17, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@fregante
Copy link

fregante commented May 17, 2020 •
edited
Loading

The readme states:

Why are images in my Markdown files not loading?

Glance only has access to the file that’s being previewed (com.apple.security.files.user-selected.read-only entitlement). Any image files referenced from Markdown are therefore not loaded.

But these images are loaded from a remote server
@samuelmeuli
Copy link
Owner

Thanks for reporting! I've already fixed this: 645c7d1.

I'm about to submit to the App Store, so you should hopefully get the fix tomorrow :)

@samuelmeuli samuelmeuli added the bug Something isn't working label May 17, 2020
@samuelmeuli
Copy link
Owner

It might be worth discussing whether remote assets should selectively be allowed. For now it's offline assets only though.

@fregante
Copy link
Author

I'm happy to hear that! Off by default sounds good.

@samuelmeuli
Copy link
Owner

Released in v1.1.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fregante @samuelmeuli