Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 V4 signature to handle no credentials. #1332

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

whitwham
Copy link
Contributor

@whitwham whitwham commented Sep 16, 2021

Signature v4 requests were trying to create authorisation strings when no credentials were present. This change adds the v2 lines that handle this. Fixes samtools/samtools#1491.

Signature v4 requests were trying to create authorisation strings when no credentials were present.  This change adds the v2 lines that handle this.
@whitwham whitwham changed the title Add the ability to handle no credentials. S3 V4 signature to handle no credentials. Sep 16, 2021
@daviesrob daviesrob self-assigned this Sep 21, 2021
@daviesrob
Copy link
Member

I've checked both with and without credentials. Looks good, thanks.

@daviesrob daviesrob merged commit dfb1947 into samtools:develop Sep 23, 2021
@whitwham whitwham deleted the s3_v4_no_creds branch September 29, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anonymous s3 bucket access
2 participants