Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/vcf: Duplicate contig header record ID #744

Closed
zaeleus opened this issue Nov 8, 2023 · 0 comments
Closed

test/vcf: Duplicate contig header record ID #744

zaeleus opened this issue Nov 8, 2023 · 0 comments
Assignees
@d-cameron
Labels
vcf

Comments

@zaeleus
Copy link

zaeleus commented Nov 8, 2023 •
edited
Loading

In test/vcf/4.3/passed/passed_meta_contig.vcf, there are two contig header records with the same ID.

##contig=<ID=1>
##contig=<ID=1,length=123456>

As per § 1.4 "Meta-information lines" (2022-11-27):

All structured lines require an ID which must be unique within their type...
@jkbonfield jkbonfield moved this to New items in GA4GH File Formats Nov 16, 2023
@jkbonfield jkbonfield moved this to New items in GA4GH File Formats Dec 4, 2023
@jkbonfield jkbonfield removed the sam label Dec 5, 2023
@daviesrob daviesrob moved this from New items to To do (backlog) in GA4GH File Formats Jan 30, 2024
@daviesrob daviesrob moved this from To do (backlog) to Progressing in GA4GH File Formats Jan 30, 2024
d-cameron added a commit that referenced this issue Apr 20, 2024
@d-cameron
#744 Corrected incorrectly duplicated header ID
2585418
@github-project-automation github-project-automation bot moved this from Progressing to Done in GA4GH File Formats Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-cameron d-cameron

Labels
vcf
Projects
GA4GH File Formats
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zaeleus @jkbonfield @d-cameron