Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dplyr 1.1.0 compatibility #1

Closed
DavisVaughan opened this issue Dec 14, 2022 · 1 comment · Fixed by #2
Closed

dplyr 1.1.0 compatibility #1

DavisVaughan opened this issue Dec 14, 2022 · 1 comment · Fixed by #2
Labels
enhancement New feature or request

Comments

@DavisVaughan
Copy link

Hi there, your package was flagged in our revdep check for the upcoming release of dplyr 1.1.0. I was going to send a PR here, but it seems like this repo is not up to date. Can you please look here instead? cran/kmscv#1
@sametsoekel sametsoekel added the enhancement New feature or request label Dec 29, 2022
@sametsoekel
Copy link
Owner

sametsoekel commented Dec 29, 2022 •
edited
Loading

Hi, thanks for the reminder. I created #2 PR. After checking --as-cran and comparing it to the old benchmark tests I will merge them.

@sametsoekel sametsoekel linked a pull request Dec 29, 2022 that will close this issue
cran/kmscv#1 #2
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cran/kmscv#1 sametsoekel/kmscv
2 participants
@DavisVaughan @sametsoekel