Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useChain([supportedChainIds]) #7

Open
dao opened this issue Aug 14, 2021 · 1 comment
Open

useChain([supportedChainIds]) #7

dao opened this issue Aug 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@dao
Copy link

dao commented Aug 14, 2021

I'm just starting to integrate vue3-eth. We support multiple chains with a configuration for each keyed by chainId. I imagine this is how most developers will approach the problem as ethereum gives you chainId rather than e.g. "ropsten" to start with. Would you consider accepting an array of supported chainIds as an improvement? e.g. useChain(['0x1', '0x3']). If argument supplied and current network not in the array, trigger wrongNetwork.

@samatechtw
Copy link
Collaborator

That seems reasonable, we do a single deploy per environment (e.g. ropsten for staging, localhost for dev, etc), but i don't see any reason not to support an array.

Just FYI, this plugin is pretty immature. It won't be abandoned because I have a couple of small apps based on it, but things like Walletconnect support won't happen for at least a couple months.

@samatechtw samatechtw added the enhancement New feature or request label Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant