From 9e2d8b8e40179ca41886115a9956bc6d8314453c Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Tue, 15 Jan 2019 12:49:45 -0800 Subject: [PATCH] test: pin regression test for #8074 to TLS 1.2 This test has a dependency on the order in which the TCP connection is made, and TLS server handshake completes. It assumes those server side events occur before the client side write callback, which is not guaranteed by the TLS API. It usually passes with TLS1.3, but TLS1.3 didn't exist at the time the bug existed. Pin the test to TLS1.2, since the test shouldn't be changed in a way that doesn't trigger a segfault in 7.7.3: - https://github.com/nodejs/node/issues/13184#issuecomment-303700377 --- test/parallel/test-tls-socket-close.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/parallel/test-tls-socket-close.js b/test/parallel/test-tls-socket-close.js index 3b2e18184b408e..52d7a24e7fa15a 100644 --- a/test/parallel/test-tls-socket-close.js +++ b/test/parallel/test-tls-socket-close.js @@ -8,6 +8,19 @@ const tls = require('tls'); const net = require('net'); const fixtures = require('../common/fixtures'); +// Regression test for https://github.com/nodejs/node/issues/8074 +// +// This test has a dependency on the order in which the TCP connection is made, +// and TLS server handshake completes. It assumes those server side events occur +// before the client side write callback, which is not guaranteed by the TLS +// API. It usally passes with TLS1.3, but TLS1.3 didn't exist at the time the +// bug existed. +// +// Pin the test to TLS1.2, since the test shouldn't be changed in a way that +// doesn't trigger a segfault in 7.7.3: +// https://github.com/nodejs/node/issues/13184#issuecomment-303700377 +tls.DEFAULT_MAX_VERSION = 'TLSv1.2'; + const key = fixtures.readKey('agent2-key.pem'); const cert = fixtures.readKey('agent2-cert.pem');