From 19fb8c64de5606d0199c365f1c797e8b19763657 Mon Sep 17 00:00:00 2001 From: Thomas Phipps Date: Thu, 27 Apr 2023 17:39:41 +0000 Subject: [PATCH 1/3] fix #63589 --- changelog/63589.fixed.md | 1 + doc/topics/reactor/index.rst | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 changelog/63589.fixed.md diff --git a/changelog/63589.fixed.md b/changelog/63589.fixed.md new file mode 100644 index 000000000000..1f63f9ee9935 --- /dev/null +++ b/changelog/63589.fixed.md @@ -0,0 +1 @@ +add documentation note about reactor state ids. diff --git a/doc/topics/reactor/index.rst b/doc/topics/reactor/index.rst index 9372e76d0240..53fbe680942a 100644 --- a/doc/topics/reactor/index.rst +++ b/doc/topics/reactor/index.rst @@ -212,6 +212,10 @@ in :ref:`local reactions `, but as noted above this is not very user-friendly. Therefore, the new config schema is recommended if the master is running a supported release. +.. note:: + state ids of reactors for runners and wheel should all be unique. they can + overwrite each other when added to the async queue. causing lost reactions + The below two examples are equivalent: +-------------------------------------------------+-------------------------------------------------+ @@ -248,6 +252,10 @@ Like :ref:`runner reactions `, the old config schema called for wheel reactions to have arguments passed directly under the name of the :ref:`wheel function ` (or in ``arg`` or ``kwarg`` parameters). +.. note:: + state ids of reactors for runners and wheel should all be unique. they can + overwrite each other when added to the async queue. causing lost reactions + The below two examples are equivalent: +-----------------------------------+---------------------------------+ From 6d7a9a16ede7779aff3d8654d190367d5b47a469 Mon Sep 17 00:00:00 2001 From: Thomas Phipps Date: Thu, 27 Apr 2023 17:58:43 +0000 Subject: [PATCH 2/3] corrections --- doc/topics/reactor/index.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/topics/reactor/index.rst b/doc/topics/reactor/index.rst index 53fbe680942a..38a27b216a75 100644 --- a/doc/topics/reactor/index.rst +++ b/doc/topics/reactor/index.rst @@ -213,8 +213,8 @@ user-friendly. Therefore, the new config schema is recommended if the master is running a supported release. .. note:: - state ids of reactors for runners and wheel should all be unique. they can - overwrite each other when added to the async queue. causing lost reactions + State ids of reactors for runners and wheels should all be unique.Tthey can + overwrite each other when added to the async queue causing lost reactions The below two examples are equivalent: @@ -253,8 +253,8 @@ wheel reactions to have arguments passed directly under the name of the :ref:`wheel function ` (or in ``arg`` or ``kwarg`` parameters). .. note:: - state ids of reactors for runners and wheel should all be unique. they can - overwrite each other when added to the async queue. causing lost reactions + State ids of reactors for runners and wheels should all be unique. They can + overwrite each other when added to the async queue causing lost reactions The below two examples are equivalent: From 84125faceb53117c405959aed6b88e7e4a46b0db Mon Sep 17 00:00:00 2001 From: Thomas Phipps Date: Thu, 27 Apr 2023 19:30:43 +0000 Subject: [PATCH 3/3] corrections number 2 --- doc/topics/reactor/index.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/topics/reactor/index.rst b/doc/topics/reactor/index.rst index 38a27b216a75..7cdadff29cdc 100644 --- a/doc/topics/reactor/index.rst +++ b/doc/topics/reactor/index.rst @@ -213,8 +213,8 @@ user-friendly. Therefore, the new config schema is recommended if the master is running a supported release. .. note:: - State ids of reactors for runners and wheels should all be unique.Tthey can - overwrite each other when added to the async queue causing lost reactions + State ids of reactors for runners and wheels should all be unique. They can + overwrite each other when added to the async queue causing lost reactions. The below two examples are equivalent: @@ -254,7 +254,7 @@ wheel reactions to have arguments passed directly under the name of the .. note:: State ids of reactors for runners and wheels should all be unique. They can - overwrite each other when added to the async queue causing lost reactions + overwrite each other when added to the async queue causing lost reactions. The below two examples are equivalent: