Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve cherrypy 400 errors to describe the underlying problem #63835

Closed
5 of 9 tasks
whytewolf opened this issue Mar 7, 2023 · 0 comments · Fixed by #63851
Closed
5 of 9 tasks

[BUG] Improve cherrypy 400 errors to describe the underlying problem #63835

whytewolf opened this issue Mar 7, 2023 · 0 comments · Fixed by #63851
Assignees
Labels
Bug broken, incorrect, or confusing behavior Salt-API

Comments

@whytewolf
Copy link
Collaborator

Description
A clear and concise description of what the bug is.

currently when encountering a 400 error in cherrypy you are just granted the 400 screen and no addition information. even worse nothing important is logged to the logs.

Setup
(Please provide relevant configs and/or SLS files (be sure to remove sensitive info. There is no general set-up of Salt.)

external_auth:
    sharedsecret:
        salt: ['.*', '@wheel', '@jobs', '@runner']
sharedsecret: testcase
rest_cherrypy:
  disable_ssl: True
  port: 8000

Please be as specific as possible and give set-up details.

  • on-prem machine
  • VM (Virtualbox, KVM, etc. please specify)
  • VM running on a cloud service, please be explicit and add details
  • container (Kubernetes, Docker, containerd, etc. please specify)
  • or a combination, please be explicit
  • jails if it is FreeBSD
  • classic packaging
  • onedir packaging
  • used bootstrap to install

Steps to Reproduce the behavior
setup 3006.x without setting up netapi_enable_clients then run any commands that try to use a client

Expected behavior
the error message is logged and the screen informs that netwpi_enable_clients needs to be setup.

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
Salt Version:
          Salt: 3006.0rc1

Dependency Versions:
          cffi: 1.14.6
      cherrypy: unknown
      dateutil: 2.8.1
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.1.2
       libgit2: 1.5.0
  looseversion: 1.0.2
      M2Crypto: 0.38.0
          Mako: Not Installed
       msgpack: 1.0.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 22.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.9.8
        pygit2: 1.11.1
        Python: 3.10.10 (main, Feb 23 2023, 05:21:34) [GCC 11.2.0]
  python-gnupg: 0.4.8
        PyYAML: 5.4.1
         PyZMQ: 23.2.0
         smmap: Not Installed
       timelib: 0.2.4
       Tornado: 4.5.3
           ZMQ: 4.3.4

System Versions:
          dist: ubuntu 22.04 jammy
        locale: utf-8
       machine: x86_64
       release: 5.15.0-60-generic
        system: Linux
       version: Ubuntu 22.04 jammy

Additional context
Add any other context about the problem here.

@whytewolf whytewolf added Bug broken, incorrect, or confusing behavior needs-triage labels Mar 7, 2023
@anilsil anilsil added this to the Sulfur v3006.0 milestone Mar 7, 2023
@anilsil anilsil changed the title [BUG] cherrypy 400 errors are not being logged enough to know what the problem actually is. [BUG] Improve cherrypy 400 errors to describe the underlying problem Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Salt-API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants