Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] win_pkg.py print debug logging of full command being run #62480

Closed
dafyddj opened this issue Aug 17, 2022 · 0 comments · Fixed by #63078
Closed

[FEATURE REQUEST] win_pkg.py print debug logging of full command being run #62480

dafyddj opened this issue Aug 17, 2022 · 0 comments · Fixed by #63078
Assignees
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Sulfur v3006.0 release code name and version Windows

Comments

@dafyddj
Copy link
Contributor

dafyddj commented Aug 17, 2022

Is your feature request related to a problem? Please describe.

When working with Windows software installers using winrepo it would be a great timesaver to know exactly what command Salt is running.
Currently the only information given is:
[INFO ] Executing command '"C:\Windows\system32\cmd.exe"' in directory 'C:\ProgramData\Salt Project\Salt\var\ca lt\minion\extrn_files\base\the.earth.li\~sgtatham\putty\0.77\w64'
which is useless for the purpose of developing a new winrepo package definition.

Describe the solution you'd like

I would like a log message such as:
[DEBUG] Executing '"msiexec" /I "C:\\ProgramData\\Salt Project\\Salt\\var\\cache\\salt\\minion\\extrn_files\\base\\the.earth.li\\~sg \\putty\\0.77\\w64\\putty-64bit-0.77-installer.msi" ALLUSERS=1 /qn'

Describe alternatives you've considered

An alternative is to break out the debugger to check on the cmd_shell and arguments variables at the point the command is run. The requested debug logging would save a lot of time.

I have looked at the options available in cmd.run_all and it doesn't look like an option exists to log the full cmd and arguments prior to running.

Additional context
Add any other context or screenshots about the feature request here.

FAO @twangboy

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

@dafyddj dafyddj added Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Aug 17, 2022
@twangboy twangboy self-assigned this Sep 22, 2022
@twangboy twangboy added Execution-Module Windows Sulfur v3006.0 release code name and version labels Sep 22, 2022
@twangboy twangboy added this to the Sulphur v3006.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Sulfur v3006.0 release code name and version Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants