[BUG] win_pkg.genrepo does not pass saltenv to template.compile_template

[afischer-opentext-com]

Description

win_pkg.genrepo does not pass saltenv to template.compile_template

While investigating an issue and digging in the code we found the function win_pkg.genrepo() calls win_pkg._repo_process_pkg_sls() which in turn call templates.compile_template().

While win_pkg.genrepo() and templates.compile_template() support an argument saltenv, the function win_pkg._repo_process_pkg_sls() does not, and therefore does not passed the desired saltenv to templates.compile_template()

Request:

This an issue when using the saltenv jinja2 variable within the repo-ng package descriptions and may be an issue when using pillarenvs. Request is to pass the variable properly.

Setup

Any Windows minion affected.

Steps to Reproduce the behavior

Have a package description

banana:
  '1.2.3':
    full_name: 'Banana {{ saltenv }}'
    installer: C:/store/banana_{{ saltenv }}.msi
    msiexec: false
    locale: en_US
    reboot: false

Run

salt MINION pkg.refresh_db saltenv=foo

Find that a package install fails, because there is no file C:/store/banana_base.msi as requested.

Expected behavior

The passed saltenv shall be used when rendering win repo-ng package descriptions

Versions Report

salt --versions-report

Salt Version:
          Salt: 3004

Dependency Versions:
          cffi: 1.14.6
      cherrypy: 18.6.1
      dateutil: 2.8.1
     docker-py: Not Installed
         gitdb: 4.0.7
     gitpython: Not Installed
        Jinja2: 2.10.1
       libgit2: Not Installed
      M2Crypto: Not Installed
          Mako: 1.1.4
       msgpack: 0.6.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     pycparser: 2.20
      pycrypto: Not Installed
  pycryptodome: 3.10.1
        pygit2: Not Installed
        Python: 3.8.8 (tags/v3.8.8:024d805, Feb 19 2021, 13:18:16) [MSC v.1928 64 bit (AMD64)]
  python-gnupg: 0.4.7
        PyYAML: 5.4.1
         PyZMQ: 19.0.0
         smmap: 4.0.0
       timelib: 0.2.4
       Tornado: 4.5.3
           ZMQ: 4.3.2

System Versions:
          dist:
        locale: cp1252
       machine: AMD64
       release: 2019Server
        system: Windows
       version: 2019Server 10.0.17763 SP0 Multiprocessor Free

Additional context

salt/salt/modules/win_pkg.py

Line 1156 in 676e3c0

_repo_process_pkg_sls(

salt/salt/modules/win_pkg.py

Line 1199 in 676e3c0

def _repo_process_pkg_sls(filename, short_path_name, ret, successful_verbose):

salt/salt/modules/win_pkg.py

Line 1210 in 676e3c0

config = salt.template.compile_template(

[twangboy]

#66181 should fix this issue