Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule.disable doesn't work in 2019.2.0 #51825

Closed
OrangeDog opened this issue Feb 26, 2019 · 4 comments
Closed

schedule.disable doesn't work in 2019.2.0 #51825

OrangeDog opened this issue Feb 26, 2019 · 4 comments
Assignees
@garethgreenaway
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Approved

Comments

@OrangeDog
Copy link
Contributor

Master and minion on 2019.2.0.
Either schedule.disable doesn't work at all, or the application of a schedule.present state turns it back on.
This is a very annoying change in behaviour from 2018.3.3.
@garethgreenaway
Copy link
Contributor

@OrangeDog To confirm, are you talking about disable which disables the entire scheduler or disable_job which disables one schedule job?

@garethgreenaway garethgreenaway self-assigned this Feb 26, 2019
@garethgreenaway garethgreenaway added this to the Blocked milestone Feb 26, 2019
@garethgreenaway garethgreenaway added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Feb 26, 2019
@OrangeDog
Copy link
Contributor Author

are you talking about disable which disables the entire scheduler

Yes

@garethgreenaway
Copy link
Contributor

@OrangeDog Thanks! That definitely shouldn't be happening. Will take a look.

@garethgreenaway garethgreenaway modified the milestones: Blocked, Approved Feb 26, 2019
@garethgreenaway garethgreenaway added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P2 Priority 2 and removed Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged labels Feb 26, 2019
@garethgreenaway garethgreenaway mentioned this issue Feb 27, 2019
Merged
@garethgreenaway garethgreenaway added the fixed-pls-verify fix is linked, bug author to confirm fix label Feb 27, 2019
@garethgreenaway
Copy link
Contributor

Closing out as this is fixed in the 2019.2 branch and will be available in the 2019.2.1 release.

@OrangeDog OrangeDog mentioned this issue Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@OrangeDog @garethgreenaway