Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top.sls-like targeting for localmods #24488

Closed
Tracked by #2
eliasp opened this issue Jun 7, 2015 · 9 comments
Closed
Tracked by #2

top.sls-like targeting for localmods #24488

eliasp opened this issue Jun 7, 2015 · 9 comments
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. P3 Priority 3 stale
Milestone

Comments

@eliasp
Copy link
Contributor

eliasp commented Jun 7, 2015

When using Dynamic Module Distribution to distribute localmods, I do this most of the time to:

  • temporarily work around an issue of an existing module
  • distribute a single fixed module from the upcoming version until this version made its way into my distribution's package repository

I believe, this is what most people use localmods for.
With this approach, I'm running into the following issues:

  • I have to manually keep track of each module when to drop it again
  • I have no control over which Minions will receive a specific module or not (e.g. CentOS still has 2014.7.x, while Debian/Ubuntu already has 2015.5.x) which might then lead to compatibility conflicts.

I'd like to see a solution which provides more finegrained control over the the distribution of localmods, e.g.

  • regular targeting based on grains etc.
  • targeting based on Minion versions (e.g. <2015.5.0 or * and !2014.7.6 and !2015.5.0)
@arnisoph
Copy link
Contributor

arnisoph commented Jun 8, 2015

+1

@jfindlay jfindlay added Feature new functionality including changes to functionality and code refactors, etc. Core relates to code central or existential to Salt labels Jun 10, 2015
@jfindlay jfindlay added this to the Approved milestone Jun 10, 2015
@jfindlay
Copy link
Contributor

@eliasp, thanks for the report.

@arnisoph
Copy link
Contributor

I think #10105 is related to this.

IMHO version management is useful for state, execution, pillar, runner, returner, outputter and cloud drivers and all the others modules. Having this would be a huge killer-feature of salt.

@jfindlay jfindlay added the P3 Priority 3 label Jun 27, 2015
@DanyC97
Copy link

DanyC97 commented Jun 29, 2015

+1111

@arnisoph
Copy link
Contributor

@thatch45 I'd love to hear your opinion about this topic. it is hard to maintain (execution or any other) modules when you can't test them in an environment without using a separate salt master. I think having the possibility of specifying execution/state module versions on top.sls level would be useful for many people!

are there any other ways to solve this problem?

@stale
Copy link

stale bot commented Dec 28, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Dec 28, 2017
@eliasp
Copy link
Contributor Author

eliasp commented Dec 29, 2017

Not stale at all!

@stale
Copy link

stale bot commented Dec 29, 2017

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Dec 29, 2017
@stale
Copy link

stale bot commented Apr 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Apr 23, 2019
@stale stale bot closed this as completed Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. P3 Priority 3 stale
Projects
None yet
Development

No branches or pull requests

4 participants