Inverted logic for starting service in standalone mode

[mrichar1]

In standalone mode, the code seems to enable the salt-minion service if master_type is defined and set to disabled:

{%- if salt_settings.minion.master_type is defined and salt_settings.minion.master_type == 'disable' %}
  service.running:
    - enable: True
{%- else %}
  service.dead:
    - enable: False

https://github.com/saltstack-formulas/salt-formula/blob/master/salt/standalone.sls#L19-L21

However the salt docs for master_type says:

this option can be set to disable and the minion will never attempt to talk to the master. This is useful for running a masterless minion daemon.

https://docs.saltstack.com/en/latest/ref/configuration/minion.html#master-type

Is the logic in standalone.sls backwards?

[aboe76]

I have tested the code standalone.sls which means running the salt minion as masterless.
You need to have a minion daemon running to do some mine/reactor stuff.
if you don't need mine/reactor then disabling the minion daemon is an option.

[mrichar1]

Ahh - I see - if the config asks for the minion to be disabled, there is an implication that is should be running, but not speaking to the master. Thanks for clearing that up! will close issue and PR.