Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of configuration in rendered configuration files #162

Closed
genuss opened this issue Jul 27, 2015 · 7 comments
Closed

Reduce amount of configuration in rendered configuration files #162

genuss opened this issue Jul 27, 2015 · 7 comments

Comments

@genuss
Copy link
Contributor

genuss commented Jul 27, 2015

For example in this one we can see many default comments.
Although this is important for new users, the comments make much harder to navigate among all this lines.
Moreover if meaning of some parameter changes and we don't syncronize the change with original, our words will be confusing.

What do you think about removing these comments?

@puneetk
Copy link
Contributor

puneetk commented Jul 27, 2015

Add a configurable file.replace state that replaces all lines that start with '#' and send over a pull request. Its a good idea.

@genuss
Copy link
Contributor Author

genuss commented Jul 27, 2015

Great, will definitely do that!

@wwentland
Copy link
Contributor

+1

@genuss
Copy link
Contributor Author

genuss commented Jul 28, 2015

Just started to do that.
If I use file.replace on manage file, than I will always get "changed" result. I suppose it's not good idea at all. Am I missing something?

@Sjd-Risca
Copy link

Yes, you're right. Maybe the best approach could be to integrate this option into the formula.
From my point of view I prefer to have the comments, both because as a reminder of what an option means, both because it's easier to highlight the diff when I do a package upgrade of saltstack.

@aboe76
Copy link
Member

aboe76 commented Feb 20, 2016

@genuss I would like to keep the comments even in the f_defaults.conf file this formula can generate,
Even though it will generate a larger file it will provide information on what each option does.

@genuss
Copy link
Contributor Author

genuss commented Feb 24, 2016

OK, as we don't have a simple solution let's leave things like they are now.

@genuss genuss closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants