Should all users created by this formula be system users?

[myii]

When preparing this formula for Debian 11 support, came across the following problem:

Setting up prometheus (2.24.1+ds-1+b5) ...
adduser: The user `prometheus' already exists, but is not a system user. Exiting.
dpkg: error processing package prometheus (--configure):
 installed prometheus package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
 prometheus

Resolved this with 0e65cc3. However, I wouldn't be surprised if this should be done for all Linux-based installations. In that case, the fix is easy:

prometheus-formula/prometheus/config/users.sls

Lines 22 to 26 in 0e65cc3

	{%- if grains.kernel|lower == 'linux' %}
	- createhome: false
	{%- if grains.get('osfinger', '') in ['Debian-11'] %}
	- system: true
	{%- endif %}

Just need to remove the nested if statements:

                    {%- if grains.kernel|lower == 'linux' %}
      - createhome: false
-                     {%- if grains.get('osfinger', '') in ['Debian-11'] %}
      - system: true
-                     {%- endif %}

[saltstack-formulas-travis]

🎉 This issue has been resolved in version 5.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀