Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Treat other_hostnames and local_interfaces as list #14

Closed
n-rodriguez opened this issue Oct 4, 2019 · 16 comments · Fixed by #15
Closed

[FEATURE] Treat other_hostnames and local_interfaces as list #14

n-rodriguez opened this issue Oct 4, 2019 · 16 comments · Fixed by #15

Comments

@n-rodriguez
Copy link
Member

No description provided.

@myii
Copy link
Member

myii commented Oct 4, 2019

Optional: How can this template be improved?

<!-- Feel free to suggest how this template can be improved. -->

@n-rodriguez: What template?!

@n-rodriguez
Copy link
Member Author

?

@myii
Copy link
Member

myii commented Oct 4, 2019

@n-rodriguez I was joking with you. That was your response to the feature_request template that was nicely laid out!

@n-rodriguez
Copy link
Member Author

@n-rodriguez I was joking with you. That was your response to the feature_request template that was nicely laid out!

Ok ^^

@myii
Copy link
Member

myii commented Oct 4, 2019

@n-rodriguez The template did show up, didn't it? Or is there some underlying issue we need to fix?

@n-rodriguez
Copy link
Member Author

@n-rodriguez The template did show up, didn't it?

It did!

@myii
Copy link
Member

myii commented Oct 4, 2019

OK, thanks for that confirmation. Sorry for the noise!

@n-rodriguez
Copy link
Member Author

OK, thanks for that confirmation. Sorry for the noise!

No problem. Tell me when you're done with #13. I've got another one to submit :)

@myii
Copy link
Member

myii commented Oct 4, 2019

No problem. Tell me when you're done with #13. I've got another one to submit :)

@n-rodriguez You're definitely keeping me busy! I'll try to look at it within the next day.

@myii
Copy link
Member

myii commented Oct 4, 2019

@n-rodriguez I just tried to ping you on IRC. Since we're deeply entwined with all of these PRs, can we get some sort of direct contact working? It would be easier to deal with certain issues.

One question, completely off-topic for this issue but at an organisational level: what Ruby linter would you recommend that we include in the Travis lint stage, for our InSpec files?

@myii
Copy link
Member

myii commented Oct 5, 2019

@n-rodriguez I've started testing running linting checks with rubocop and it's looking good. Any thoughts?

@n-rodriguez
Copy link
Member Author

Any thoughts?

rubocop is the way to go 👍

@myii
Copy link
Member

myii commented Oct 5, 2019

@n-rodriguez These are the changes for the template-formula -- what do you think?

@n-rodriguez
Copy link
Member Author

@n-rodriguez These are the changes for the template-formula -- what do you think?

I'm not for running linters first. If linters don't pass, tests don't run :/

Why not adding rubocop in the Gemfile?

@myii
Copy link
Member

myii commented Oct 5, 2019

I'm not for running linters first. If linters don't pass, tests don't run :/

@n-rodriguez The linters is just an idea of mine, more to do with a pragmatic solution to our limited shared resources on Travis. Many times, we've got complete test runs completing, even though each of them is going to fail because of lint issues. That's not a finalised plan, though.

Why not adding rubocop in the Gemfile?

Yes, that will be the final plan, I was just messing around for now.

The important thing: what about the actual changes made? Are you happy with those or is there some things that could be done differently?

@saltstack-formulas-travis

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants