-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Treat other_hostnames and local_interfaces as list #14
Comments
@n-rodriguez: What template?! |
? |
@n-rodriguez I was joking with you. That was your response to the |
Ok ^^ |
@n-rodriguez The template did show up, didn't it? Or is there some underlying issue we need to fix? |
It did! |
OK, thanks for that confirmation. Sorry for the noise! |
No problem. Tell me when you're done with #13. I've got another one to submit :) |
@n-rodriguez You're definitely keeping me busy! I'll try to look at it within the next day. |
@n-rodriguez I just tried to ping you on IRC. Since we're deeply entwined with all of these PRs, can we get some sort of direct contact working? It would be easier to deal with certain issues. One question, completely off-topic for this issue but at an organisational level: what Ruby linter would you recommend that we include in the Travis |
@n-rodriguez I've started testing running linting checks with |
|
@n-rodriguez These are the changes for the |
I'm not for running linters first. If linters don't pass, tests don't run :/ Why not adding |
@n-rodriguez The linters is just an idea of mine, more to do with a pragmatic solution to our limited shared resources on Travis. Many times, we've got complete test runs completing, even though each of them is going to fail because of lint issues. That's not a finalised plan, though.
Yes, that will be the final plan, I was just messing around for now. The important thing: what about the actual changes made? Are you happy with those or is there some things that could be done differently? |
🎉 This issue has been resolved in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.
The text was updated successfully, but these errors were encountered: