From 5fc5b478f4e72bfe47e2aa6bdcd5fc6bc26655d3 Mon Sep 17 00:00:00 2001 From: Patrick Carlo-Hickman Date: Fri, 31 May 2024 15:15:17 -0400 Subject: [PATCH 1/3] Add a null authenticator implementation. --- src/Http/Auth/NullAuthenticator.php | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 src/Http/Auth/NullAuthenticator.php diff --git a/src/Http/Auth/NullAuthenticator.php b/src/Http/Auth/NullAuthenticator.php new file mode 100644 index 00000000..bf1156ed --- /dev/null +++ b/src/Http/Auth/NullAuthenticator.php @@ -0,0 +1,19 @@ + Date: Sun, 9 Jun 2024 11:43:32 +0100 Subject: [PATCH 2/3] Added test --- tests/Unit/AuthenticatesRequestsTest.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/Unit/AuthenticatesRequestsTest.php b/tests/Unit/AuthenticatesRequestsTest.php index 5cecf34c..d872cb0d 100644 --- a/tests/Unit/AuthenticatesRequestsTest.php +++ b/tests/Unit/AuthenticatesRequestsTest.php @@ -5,8 +5,10 @@ use GuzzleHttp\RequestOptions; use Saloon\Exceptions\SaloonException; use Saloon\Http\Auth\MultiAuthenticator; +use Saloon\Http\Auth\NullAuthenticator; use Saloon\Http\Auth\TokenAuthenticator; use Saloon\Http\Auth\HeaderAuthenticator; +use Saloon\Tests\Fixtures\Connectors\DefaultAuthenticatorConnector; use Saloon\Tests\Fixtures\Requests\UserRequest; use Saloon\Tests\Fixtures\Connectors\ArraySenderConnector; @@ -106,3 +108,14 @@ 'X-API-Key' => 'api-key', ]); }); + +test('you can use a null authenticator to disable default authentication entirely', function () { + $connector = new DefaultAuthenticatorConnector; + $request = new UserRequest; + + $request->authenticate(new NullAuthenticator); + + $pendingRequest = $connector->createPendingRequest($request); + + expect($pendingRequest->headers()->all())->toEqual(['Accept' => 'application/json']); +}); From 528dd236e99329c88153e3d42877b70ef5af9948 Mon Sep 17 00:00:00 2001 From: Sammyjo20 <29132017+Sammyjo20@users.noreply.github.com> Date: Sun, 9 Jun 2024 11:44:38 +0100 Subject: [PATCH 3/3] Code style --- tests/Unit/AuthenticatesRequestsTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Unit/AuthenticatesRequestsTest.php b/tests/Unit/AuthenticatesRequestsTest.php index d872cb0d..22d3c77b 100644 --- a/tests/Unit/AuthenticatesRequestsTest.php +++ b/tests/Unit/AuthenticatesRequestsTest.php @@ -4,13 +4,13 @@ use GuzzleHttp\RequestOptions; use Saloon\Exceptions\SaloonException; -use Saloon\Http\Auth\MultiAuthenticator; use Saloon\Http\Auth\NullAuthenticator; +use Saloon\Http\Auth\MultiAuthenticator; use Saloon\Http\Auth\TokenAuthenticator; use Saloon\Http\Auth\HeaderAuthenticator; -use Saloon\Tests\Fixtures\Connectors\DefaultAuthenticatorConnector; use Saloon\Tests\Fixtures\Requests\UserRequest; use Saloon\Tests\Fixtures\Connectors\ArraySenderConnector; +use Saloon\Tests\Fixtures\Connectors\DefaultAuthenticatorConnector; test('you can add basic auth to a request', function () { $request = new UserRequest;