Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @opentelemetry/instrumentation from 0.48.0 to 0.49.1 #105

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps @opentelemetry/instrumentation from 0.48.0 to 0.49.1.

Release notes

Sourced from @​opentelemetry/instrumentation's releases.

Experimental v0.49.1

0.49.1

🐛 (Bug Fix)

Experimental v0.49.0

0.49.0

💥 Breaking Change

  • fix(otlp-exporter-base)!: remove unload event from OTLPExporterBrowserBase #4438 @​eldavojohn
    • Reason: The 'unload' event prevents sites from taking advantage of Google's backward/forward cache and will be deprecated. It is now up to the consuming site to implement these shutdown events.
    • This breaking change affects users under this scenario:
      1. A user extends the exporter and overrides the shutdown function, and does something which is usually called by the unload listener
      2. We remove the unload event listener
      3. That user's overridden shutdown function no longer gets called

🚀 (Enhancement)

🐛 (Bug Fix)

  • fix(sdk-node): allow using samplers when the exporter is defined in the environment #4394 @​JacksonWeber
  • fix(instrumentation): normalize paths for internal files in scoped packages #4467 @​pichlermarc
    • Fixes a bug where, on Windows, internal files on scoped packages would not be instrumented.
  • fix(otlp-transformer): only use BigInt inside hrTimeToNanos() #4484 @​pichlermarc
  • fix(instrumentation-fetch): do not enable in Node.js; clarify in docs this instr is for web fetch only #4498 @​trentm
Commits
  • 3920b15 chore: prepare release Experimental 0.49.1 (#4517)
  • 8e1996e fix(instrumentation): remove peer-dependency on @​opentelemetry/api-logs (#4515)
  • 7be35c7 chore: prepare release API 1.8.0/Core 1.21.0/Experimental 0.49.0 (#4504)
  • 05720cc Fix broken link to getting started page (#4511)
  • f1b2c6d fix a wrong internal link in examples readme (#4512)
  • 5637e2a chore: Semantic Conventions export individual strings (#4298)
  • aff48a1 fix(instr-fetch): do not enable in Node.js; clarify in docs this instr is for...
  • 89caef9 Add @​david-luna to triagers (#4497)
  • 356ef8a chore: remove unload event from OTLPExporterBrowserBase (#4438)
  • 5bc8ced fix(otlp-transformer): only use BigInt inside hrTimeToNanos() (#4484)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js) from 0.48.0 to 0.49.1.
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-js@experimental/v0.48.0...experimental/v0.49.1)

---
updated-dependencies:
- dependency-name: "@opentelemetry/instrumentation"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 4, 2024
@dependabot dependabot bot requested a review from saidsef March 4, 2024 23:54
@saidsef
Copy link
Owner

saidsef commented Mar 5, 2024

/code review

@saidsef
Copy link
Owner

saidsef commented Mar 5, 2024

🤖

Review Summary

package.json

  • Modification: Updated @opentelemetry/instrumentation from ^0.48.0 to ^0.49.1.
  • Comment: The update is minor and adheres to semantic versioning, suggesting non-breaking changes. Ensure compatibility with the rest of the project dependencies.

package-lock.json

  • Modifications:
    • Updated project version from 1.8.28 to 1.8.29.
    • Updated @opentelemetry/instrumentation from 0.48.0 to 0.49.1.
    • Added @opentelemetry/api-logs version 0.49.1 as a new dependency for @opentelemetry/instrumentation.
  • Comments:
    • The project version bump is consistent with the dependency update.
    • The addition of @opentelemetry/api-logs is likely a result of the updated @opentelemetry/instrumentation dependency. Verify that this new dependency does not introduce any unexpected behaviour.
    • Ensure that the updated @opentelemetry/instrumentation version does not conflict with other @opentelemetry dependencies.

General Comments

  • The dependency update appears to be handled correctly with both package.json and package-lock.json updated accordingly.
  • No direct issues or conflicts identified from the changes made. However, it's recommended to run tests to ensure that the update does not affect the application's functionality.
  • Consider verifying the release notes and changelog for @opentelemetry/instrumentation 0.49.1 to understand the changes and any potential impact on the project.

> gpt-4-turbo-preview

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 5, 2024

Looks like @opentelemetry/instrumentation is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Mar 5, 2024
@dependabot dependabot bot deleted the dependabot-npm_and_yarn-opentelemetry-instrumentation-0.49.1 branch March 5, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant