Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macaulay2 interface update/improvement for version 1.3.1 #7897

Closed
novoselt opened this issue Jan 11, 2010 · 10 comments
Closed

Macaulay2 interface update/improvement for version 1.3.1 #7897

novoselt opened this issue Jan 11, 2010 · 10 comments

Comments

@novoselt
Copy link
Member

See also #5467 and #7915 (!).

These patches change the prompt detection/stripping and update doctests to cause no errors with Macaulay2 1.3.1.

Improvements/fixes achieved:

  • examples in Macaulay2 documentation (which include input prompts) do not break the interaction with Sage;
  • empty/whitespace/comment lines can be executed;
  • multiline commands can be executed;
  • stripping output prompts will not cut error messages if they occur (e.g. the first call "help Thing" currently shows some errors in Macaulay2);
  • "macaulay2.restart()" does not print a useless variable name.

This is done by:

  • changing input and input continuation prompts;
  • starting with a big line number to make all output labels of the same width;
  • making sure that only output labels and spaces are stripped from the output.

These patches make tickets #7882 and #7888 unnecessary.

Component: interfaces

Keywords: Macaulay2, interface

Author: Andrey Novoseltsev

Reviewer: Mike Hansen

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7897

@novoselt

This comment has been minimized.

@novoselt
Copy link
Member Author

comment:2

I changed my mind about importance of "restart" command in the middle of the code after seeing a talk today. So the patch is rewritten to allow it everywhere. All doctests still pass with both patches applied.

@novoselt
Copy link
Member Author

novoselt commented Feb 1, 2010

@novoselt
Copy link
Member Author

novoselt commented Feb 1, 2010

comment:3

Renamed patches and commit messages to follow conventions. Apply both patches starting with "trac_7897"

@williamstein

This comment has been minimized.

@novoselt

This comment has been minimized.

@novoselt novoselt added this to the sage-4.4 milestone Apr 11, 2010
@mwhansen
Copy link
Contributor

mwhansen commented Jul 9, 2010

comment:7

Looks good to me.

@mwhansen
Copy link
Contributor

mwhansen commented Jul 9, 2010

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Jul 9, 2010

comment:8

Also apply #5467 and #7915.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 21, 2010

Merged: sage-4.5.2.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants