Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph.edge_connectivity #7601

Closed
nathanncohen mannequin opened this issue Dec 4, 2009 · 9 comments
Closed

Graph.edge_connectivity #7601

nathanncohen mannequin opened this issue Dec 4, 2009 · 9 comments
Assignees
@rlmill
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-4.3

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 4, 2009

As the title says, this patch implements the function edge_connectivity for Graphs.

You could be in need of #7270 and GLPK from http://sagemath.org/packages/optional/glpk-4.38.p4.spkg depending on the version of Sage you are using !!!

Component: graph theory

Author: Nathann Cohen

Reviewer: Robert Miller

Merged: sage-4.3.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7601
@nathanncohen nathanncohen mannequin added this to the sage-4.3.1 milestone Dec 4, 2009
@nathanncohen nathanncohen mannequin assigned rlmill Dec 4, 2009
@nathanncohen nathanncohen mannequin added the s: needs review label Dec 4, 2009
@nathanncohen

This comment has been minimized.

Sign in to view
@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 15, 2009

comment:3

same as #7594 and #7599 - more doctests!

@rlmill rlmill mannequin added s: needs work and removed s: needs review labels Dec 15, 2009
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 16, 2009

comment:4

updated !

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 16, 2009

comment:5

The point of doctests is partially to test each use case of a function. This function has three different inputs, and all of your tests use the default value. This isn't testing certain code paths in your function, and if someone messed up that part in a future patch, the tests as is wouldn't catch them. Please check and make sure you're testing each case.

@rlmill rlmill mannequin added s: needs work and removed s: needs review labels Dec 16, 2009
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 16, 2009

Attachment: trac_7601.patch.gz

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 16, 2009

comment:6

Updated !! :-)

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 16, 2009

Author: Nathann Cohen

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 16, 2009

Reviewer: Robert Miller

@mwhansen
Copy link
Contributor

Merged: sage-4.3.rc1

@mwhansen mwhansen modified the milestones: sage-4.3.1, sage-4.3 Dec 20, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlmill rlmill

Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.3
Development

No branches or pull requests
1 participant
@mwhansen