Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement is_prime() for ideals #7450

Closed
aghitza opened this issue Nov 13, 2009 · 6 comments
Closed

implement is_prime() for ideals #7450

aghitza opened this issue Nov 13, 2009 · 6 comments

Comments

@aghitza
Copy link

aghitza commented Nov 13, 2009

The attached patch implements a generic primality testing method for ideals. It is based on the computation of the associated primes of an ideal, and so at the moment will only work for ideals that have this implemented (e.g. ideals in multivariate polynomial rings that Singular can handle).

There are also a few related methods such as is_primary() and embedded_primes().

Component: commutative algebra

Keywords: prime ideal

Author: Alex Ghitza

Reviewer: Martin Albrecht

Merged: sage-4.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7450

@malb
Copy link
Member

malb commented Nov 13, 2009

comment:1

Other than the last nitpick the patch looks fine.

@aghitza
Copy link
Author

aghitza commented Nov 13, 2009

comment:2

Aha! Thanks for the pointer for citations. I had looked in the developer guide and there was nothing about this (I'll open a new ticket to fix that).

I have replaced the patch with one that has the proper citation markup. Having had a look at the html output, I also fixed the markup for apply_morphism.

@aghitza
Copy link
Author

aghitza commented Nov 15, 2009

comment:3

Attachment: trac_7450.patch.gz

And I replaced it once more, having added an optional argument to is_primary to check whether an ideal is primary wrt a given prime ideal; also added more doctests borrowed from the Macaulay2 docs.

@malb
Copy link
Member

malb commented Nov 16, 2009

comment:4

Looks good.

@mwhansen
Copy link
Contributor

Reviewer: Martin Albrecht

@mwhansen
Copy link
Contributor

Merged: sage-4.3.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants