-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New repo: sagemath/mols-handbook-data.git #37025
Comments
Please don't. This is just a single text file which contains a bunch of number copied from a handbook. It's not even used in sagemath, except for testing purposes. See what I did in #37024. |
I looked at it yesterday. I've made a few minor improvements on top of what was there:
Like you say, this code barely belongs in sage. Why not move it out of sage? If we ever want to delete the one function that uses it (and eliminate the dependency), then our job will be that much easier: we'll be able to say "just |
Just don't, please. There's really no need to fragment everything in separate packages just because. It's not like the file is going anywhere, even if sagemath were to drop it. I think it's a complete waste of time (yours and others, now and in the future). Why not have a |
It's already a separate package, a nonstandard one that is coupled to sage but can't be discovered from within sage. The last time anyone touched this stuff was a decade ago, and the work to package it is already done. So whatever time was going to be wasted has already been wasted. And in return, we get
Sage is already odd enough. The new package isn't tied to sage any more and would be simply |
You are certainly entitled to waste your own time as you wish. But making a package for this will waste other people time for (IMO) no gain. Distros will have to repackage a stupid package (current combinatorial_designs) into another stupid package, with all the deprecation, replacement, etc. It's another package for which sagemath becomes upstream, another package in pypi, etc.
Distro package is already there. It's just files placed somewhere. With #37024 the files can be found either in This for a "real" database (e.g. cremona's database of elliptic curves which is quite big). In this case, distro package can be removed after #37024. Nothing is simpler than nothing. Note that the
Not useful for anything. ¿Do you use it? ¿Who will use it? ¿Who will maintain it? It's just a list of numbers, let's keep it a list of numbers in a place where it's used (and tested, fwiw: how are you going to test it, sure your package will not
It becomes a file after #37024 and one can just
It stays in the only place it has a chance to be useful, if any.
🤷 |
I've never gotten so much nothing done in my life, talk about wasted time. |
Problem Description
As part of #30914, I've created https://github.com/orlitzky/mols-handbook-data to replace the old combinatorial_designs package with something that can be detected by python.
Proposed Solution
Can I please have access to a new
sagemath/mols-handbook-data.git
repo to push my changes? This is required before the first release if we want the docs to point to the right place.Alternatives Considered
N/A
Additional Information
No response
Is there an existing issue for this?
The text was updated successfully, but these errors were encountered: