Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda config does not respect constraints in install_requires #35074

Open
2 tasks done
tobiasdiez opened this issue Feb 11, 2023 · 3 comments
Open
2 tasks done

Conda config does not respect constraints in install_requires #35074

tobiasdiez opened this issue Feb 11, 2023 · 3 comments

Comments

@tobiasdiez
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.

Did you read the documentation and troubleshoot guide?

  • I have read the documentation and troubleshoot guide

Environment

- **OS**: Win 11
- **Sage Version**: latest

Steps To Reproduce

Run ./bootstrap-conda.

Expected Behavior

The generated conda config file should contain the same version constraints as specified in the install-requires files.

Actual Behavior

The generated config does not contain the version constraints, or incompatible ones. E.g. at https://github.com/tobiasdiez/sage/actions/runs/4150784209/jobs/7180663661, you can see that networkx, lrcalc and ptyprocess are not specified correctly.

Additional Information

@mkoeppe can you have a look at this? I tried to do this, but since your latest optimizations in the bootstrap-conda script my bash skills are no longer sufficient to understand what's going on there in detail (e.g. somewhere spaces are treated as array separators, so one cannot simply pull in the install-requires files).

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 11, 2023

It is not clear to me how to transform version specifiers according to PEP 440 to corresponding conda version specifiers. @isuruf, can you help?

@isuruf
Copy link
Member

isuruf commented Feb 12, 2023

I'm not sure I understand. Can you give some examples?

@tobiasdiez
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants