Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construct QuadraticForm and BinaryQF objects from polynomial #34863

Closed
yyyyx4 opened this issue Dec 19, 2022 · 10 comments
Closed

construct QuadraticForm and BinaryQF objects from polynomial #34863

yyyyx4 opened this issue Dec 19, 2022 · 10 comments

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Dec 19, 2022

QuadraticForm and BinaryQF objects have a .polynomial() method to return the quadratic form represented as a multivariate polynomial, but the converse is not currently available. This patch adds it.

Component: quadratic forms

Author: Lorenz Panny

Branch/Commit: 9224d7e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34863

@yyyyx4 yyyyx4 added this to the sage-9.8 milestone Dec 19, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Changed commit from 87c8658 to a3a94c0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a3a94c0also implement .from_polynomial() for BinaryQF

@yyyyx4

This comment has been minimized.

@yyyyx4 yyyyx4 changed the title construct QuadraticForm from polynomial construct QuadraticForm and BinaryQF objects from polynomial Dec 19, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 20, 2022

comment:3
+        Construct a :class:`BinaryQF` from a bivariate polynomial
+        with integer coefficients. Converse of :meth:`polynomial`.

I think that should be "inverse"

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 20, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 20, 2022

comment:4

Other than that, LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2022

Changed commit from a3a94c0 to 9224d7e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9224d7econverse -> inverse

@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 21, 2022

comment:6

Thanks! Changed the word and setting to positive review under the assumption that that's what your comment:4 meant.

@vbraun
Copy link
Member

vbraun commented Jan 29, 2023

Changed branch from public/construct_quadratic_form_from_polynomial to 9224d7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants