-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
construct QuadraticForm and BinaryQF objects from polynomial #34863
Milestone
Comments
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
yyyyx4
changed the title
construct QuadraticForm from polynomial
construct QuadraticForm and BinaryQF objects from polynomial
Dec 19, 2022
comment:3
I think that should be "inverse" |
Reviewer: Matthias Koeppe |
comment:4
Other than that, LGTM. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Thanks! Changed the word and setting to positive review under the assumption that that's what your comment:4 meant. |
Changed branch from public/construct_quadratic_form_from_polynomial to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QuadraticForm
andBinaryQF
objects have a.polynomial()
method to return the quadratic form represented as a multivariate polynomial, but the converse is not currently available. This patch adds it.Component: quadratic forms
Author: Lorenz Panny
Branch/Commit:
9224d7e
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/34863
The text was updated successfully, but these errors were encountered: