Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute matrix kernels modulo composites #34862

Closed
yyyyx4 opened this issue Dec 19, 2022 · 3 comments · Fixed by #34968
Closed

compute matrix kernels modulo composites #34862

yyyyx4 opened this issue Dec 19, 2022 · 3 comments · Fixed by #34968
Labels
c: linear algebra p: major / 3 t: enhancement

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Dec 19, 2022 •
edited by mkoeppe
Loading

Currently, Sage cannot compute kernels of matrices over Zmod(n) for composite n.

This patch adds a call path from Matrix.right_kernel_matrix() to PARI's matkermod() function for matrices defined over IntegerModRings with composite modulus.

Also, for symmetry we add a .left_kernel_matrix() method that simply calls .transpose() and defers to .right_kernel_matrix().

Component: linear algebra

Author: Lorenz Panny

Issue created by migration from https://trac.sagemath.org/ticket/34862
@yyyyx4 yyyyx4 added this to the sage-9.8 milestone Dec 19, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2022

Changed commit from 8ed83fa to a005c96

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a005c96fix doctests

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@yyyyx4 yyyyx4 mentioned this issue Feb 6, 2023
Merged
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2023

Removed branch from the issue description because it has been replaced by PR #34968

@vbraun vbraun closed this as completed in 0b88463 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compute matrix kernels modulo composites yyyyx4/sage
2 participants
@mkoeppe @yyyyx4