Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better position the camera in 3d graphics #34822

Closed
kwankyu opened this issue Dec 4, 2022 · 13 comments · Fixed by #34960
Closed

Better position the camera in 3d graphics #34822

kwankyu opened this issue Dec 4, 2022 · 13 comments · Fixed by #34960
Labels
c: graphics p: minor / 4 t: bug

Comments

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 4, 2022 •
edited by mkoeppe
Loading

Compare "before" and "after" of

var('x,y,z')
implicit_plot3d((sqrt(x*x+y*y)-3)^2 + z*z - 1, (x,-4,4), (y,-4,4), (z,-1,1))

by the initial view and rotated views.

Component: graphics

Author: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34822
@kwankyu kwankyu added this to the sage-9.8 milestone Dec 4, 2022
@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 4, 2022

Branch: u/klee/better_position_the_camera_in_3d_graphics

@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 4, 2022

Author: Kwankyu Lee

@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 4, 2022

Commit: c06d290

@kwankyu
Copy link
Collaborator Author

kwankyu commented Dec 4, 2022

New commits:

c06d290Improve camera positioning for threejs

@kwankyu

This comment has been minimized.

Sign in to view
@kwankyu

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2022

Changed commit from c06d290 to 067b88b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

067b88bAdjust angles to be more human-friendly

@kwankyu

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2022

Changed commit from 067b88b to 0c45076

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0c45076Edit the comment

@kwankyu

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@kwankyu kwankyu mentioned this issue Feb 6, 2023
Merged
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2023

Removed branch from issue description; replaced by PR #34960

@vbraun vbraun closed this as completed in 8e038e1 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: minor / 4 t: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve camera positioning for threejs kwankyu/sage
2 participants
@kwankyu @mkoeppe