Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Clifford algebra multiplication #34707

Closed
tscrim opened this issue Oct 31, 2022 · 9 comments
Closed

Bug in Clifford algebra multiplication #34707

tscrim opened this issue Oct 31, 2022 · 9 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Oct 31, 2022

This is a really bad associativity failure:

sage: r = ZZ['r'].fraction_field().gen()
sage: Q = QuadraticForm(r.parent(), 2, [0,r,0])
sage: C.<p,q> = CliffordAlgebra(Q)
sage: q * (p * q)
r*q
sage: (q * p) * q
-r*p*q + r^2

CC: @trevorkarn @fchapoton

Component: algebra

Keywords: Clifford

Author: Travis Scrimshaw

Branch/Commit: 4d56288

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/34707

@tscrim tscrim added this to the sage-9.8 milestone Oct 31, 2022
@tscrim
Copy link
Collaborator Author

tscrim commented Oct 31, 2022

comment:1

The first answer is the correct answer.

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 31, 2022

Author: Travis Scrimshaw

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 31, 2022

comment:2

Okay, it is a very special case. It was checking that the first element of the LHS when the RHS was single monomial. In this example, the first returned term happened to be the constant term, so it thought it just needed to multiply the LHS by that scalar. So it actually is not so bad of a bug, just a special case.


New commits:

4d56288Checking that the RHS is a scalar of 1, not the LHS.

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 31, 2022

Commit: 4d56288

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 31, 2022

@fchapoton
Copy link
Contributor

comment:3

ok if the bot comes back green

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 1, 2022

comment:5

Thank you! This has been around for a while and is a somewhat embarrassing bug from me...

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from public/algebra/clifford_algebra_mult-34707 to 4d56288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants