fix E251 in geometry and manifolds

[fchapoton]

about

E251 unexpected spaces around keyword / parameter equals

CC: @tscrim @kwankyu @slel @dcoudert

Component: geometry

Author: Frédéric Chapoton

Branch/Commit: 0fdd5a2

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34331

[fchapoton]

New commits:

67c7a18

E251 in geometry/ and manifolds/

[fchapoton]

Commit: 67c7a18

[fchapoton]

Branch: u/chapoton/34331

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c648547

fix mistake

[sagetrac-git]

Changed commit from 67c7a18 to c648547

[fchapoton]

comment:3

green lights, so please review

[dcoudert]

comment:4

The patchbot reports an error

[sagemath_doc_html-none] [diophanti] The inventory files are in ../../local/share/doc/sage/inventory/en/reference/diophantine_approximation.
[sagemath_doc_html-none] Build finished. The built documents can be found in /home/chapoton/sage/local/share/doc/sage/inventory/en/reference/diophantine_approximation
[sagemath_doc_html-none] Error building the documentation.
[sagemath_doc_html-none] Traceback (most recent call last):
[sagemath_doc_html-none]   File "/home/chapoton/sage/local/var/lib/sage/venv-python3.10.5/lib/python3.10/runpy.py", line 196, in _run_module_as_main
[sagemath_doc_html-none]     return _run_code(code, main_globals, None,
[sagemath_doc_html-none]   File "/home/chapoton/sage/local/var/lib/sage/venv-python3.10.5/lib/python3.10/runpy.py", line 86, in _run_code
[sagemath_doc_html-none]     exec(code, run_globals)
[sagemath_doc_html-none]   File "/home/chapoton/sage/pkgs/sage-docbuild/sage_docbuild/__main__.py", line 498, in <module>
[sagemath_doc_html-none]     sys.exit(main())
[sagemath_doc_html-none]   File "/home/chapoton/sage/pkgs/sage-docbuild/sage_docbuild/__main__.py", line 495, in main
[sagemath_doc_html-none]     builder()
[sagemath_doc_html-none]   File "/home/chapoton/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 807, in _wrapper
[sagemath_doc_html-none]     self.write_auto_rest_file(module_name)
[sagemath_doc_html-none]   File "/home/chapoton/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 1111, in write_auto_rest_file
[sagemath_doc_html-none]     title = self.get_module_docstring_title(module_name)
[sagemath_doc_html-none]   File "/home/chapoton/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 1072, in get_module_docstring_title
[sagemath_doc_html-none]     __import__(module_name)
[sagemath_doc_html-none]   File "/home/chapoton/sage/src/sage/geometry/pseudolines.py", line 171
[sagemath_doc_html-none]     def __init__(self, seq, encoding "auto"):
[sagemath_doc_html-none]                                      ^^^^^^
[sagemath_doc_html-none] SyntaxError: invalid syntax
[sagemath_doc_html-none] 
[sagemath_doc_html-none]     Note: incremental documentation builds sometimes cause spurious
[sagemath_doc_html-none]     error messages. To be certain that these are real errors, run
[sagemath_doc_html-none]     "make doc-clean doc-uninstall" first and try again.
[sagemath_doc_html-none] make[4]: *** [Makefile:27: doc-inventory--reference-discrete_geometry] Error 1
[sagemath_doc_html-none] make[4]: *** Waiting for unfinished jobs....
[sagemath_doc_html-none] [databases] The inventory files are in ../../local/share/doc/sage/inventory/en/reference/databases.
[sagemath_doc_html-none] Build finished. The built documents can be found in /home/chapoton/sage/local/share/doc/sage/inventory/en/reference/databases
[sagemath_doc_html-none] make[3]: *** [Makefile:44: doc-inventory-reference] Error 2
make[2]: *** [Makefile:3084: sagemath_doc_html-SAGE_DOCS-no-deps] Error 2
make[1]: *** [Makefile:3084: /home/chapoton/sage/local/var/lib/sage/installed/sagemath_doc_html-none] Error 2
make[1]: Leaving directory '/home/chapoton/sage/build/make'

[fchapoton]

comment:5

pas pour la derniere version de la branche : j'ai deja corrigé ce probleme dans le dernier commit

[dcoudert]

comment:6

why not defining this list before the return statement ? it might improve readability

+                                   VERTICES=[[1] + v for v in self.vertices_list()] \
+                                   + [[0] + r for r in self.rays_list()],

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0fdd5a2

some details in polyhedron/base

[sagetrac-git]

Changed commit from c648547 to 0fdd5a2

[fchapoton]

comment:8

voilà

[dcoudert]

comment:9

Merci.

[dcoudert]

Reviewer: David Coudert

[vbraun]

Changed branch from u/chapoton/34331 to 0fdd5a2