Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove imports from sage.rings.all in sage.calculus, functions, symbolic #34192

Closed
mkoeppe opened this issue Jul 16, 2022 · 10 comments
Closed

Remove imports from sage.rings.all in sage.calculus, functions, symbolic #34192

mkoeppe opened this issue Jul 16, 2022 · 10 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 16, 2022

CC: @nbruin

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 9d3577e

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34192
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 16, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2022

Branch: u/mkoeppe/remove_imports_from_sage_rings_all_in_sage_calculus__functions__symbolic

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2022

Commit: fe7ed4c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2022

New commits:

fe7ed4csrc/sage/{symbolic,calculus,functions}: Remove imports from sage.rings.all

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Changed commit from fe7ed4c to 9d3577e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9d3577esrc/sage/symbolic/series_impl.pxi: Untabify

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 27, 2022

comment:5

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 27, 2022

Reviewer: Kwankyu Lee

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 27, 2022

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/mkoeppe/remove_imports_from_sage_rings_all_in_sage_calculus__functions__symbolic to 9d3577e

@vbraun vbraun closed this as completed in 735daa4 Aug 30, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @mkoeppe