Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycodestyle cleanup in src/sage/graphs/graph_coloring.pyx #34073

Closed
dcoudert opened this issue Jun 25, 2022 · 8 comments
Closed

pycodestyle cleanup in src/sage/graphs/graph_coloring.pyx #34073

dcoudert opened this issue Jun 25, 2022 · 8 comments

Comments

@dcoudert
Copy link
Contributor

Fix all issues reported by pycodestyle.

Component: graph theory

Author: David Coudert

Branch/Commit: 07cb878

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34073

@dcoudert dcoudert added this to the sage-9.7 milestone Jun 25, 2022
@dcoudert
Copy link
Contributor Author

New commits:

07cb878trac #34073: cleanup src/sage/graphs/graph_coloring.pyx

@dcoudert
Copy link
Contributor Author

Commit: 07cb878

@dcoudert
Copy link
Contributor Author

Branch: public/graphs/34073_coloring

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 12, 2022

comment:2

You inserted an additional blank line between function definitions. What is the rationale of this change? The rule is one blank line around function definitions and double blank lines around class definitons. No?

I do not object to the two blank lines here. But I am just curious if there is a rule that I do not know.

@dcoudert
Copy link
Contributor Author

comment:3

According pycodestyle, in this case this is E302 expected 2 blank lines, found 1. For class it is E305 expected 2 blank lines after class or function definition.

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 12, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 12, 2022

comment:4

Okay. I found Surround top-level function and class definitions with two blank lines. in PEP8, which seems the origin of E302 and E305.

@vbraun
Copy link
Member

vbraun commented Aug 1, 2022

Changed branch from public/graphs/34073_coloring to 07cb878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants