Fix map_reduce doctest #33834
Comments
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
comment:4
dup of #33846 |
|
comment:5
note that sleep should take an integer or a float as input, not any sage type maybe one can redo my changes from #33846 here ? |
|
comment:7
ok, I have incorporated my changes here. I will now close the other ticket. |
|
Changed author from Tobias Diez to Tobias Diez, Frédéric Chapoton |
|
comment:9
note that the build and test badge is still red, for another reasons related to not-working coverage.. |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:11
hmm, doctests do not pass... |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:13
still failing |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:15
oh, boy, a green middle badge at last ! Positive review from me. Please set to positive of you agree. |
|
Reviewer: Tobias Diez, Frédéric Chapoton |
|
comment:16
Yeah, finally! Thank you for your work in this direction. I've set it now to positive review and set the priority to "blocker" so that it hopefully still makes it into 9.6 (since there are only changes to the doctests it shouldn't introduce any serious bugs). Please set it back if you don't agree. |
|
comment:17
I don't think that's worth delaying the release for |
|
Changed branch from public/misc/fix_map_reduce_test to |
One doctest continuously fails in the build workflow. I couldn't reproduce the error locally, but hopefully it goes away by slightly increasing the timeout from 1sec to 1.5sec.
We also extend the doctest to provide a bit more debug information, and to actually test parallel processing by using two roots and thus two threads.
Local debug output:
CC: @dimpase @mkoeppe @fchapoton
Component: misc
Author: Tobias Diez, Frédéric Chapoton
Branch/Commit:
7fe3812Reviewer: Tobias Diez, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/33834
The text was updated successfully, but these errors were encountered: