Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move integration and volume to Polyhedron_base7 #33583

Closed
kliem opened this issue Mar 28, 2022 · 14 comments
Closed

Move integration and volume to Polyhedron_base7 #33583

kliem opened this issue Mar 28, 2022 · 14 comments

Comments

@kliem
Copy link
Contributor

kliem commented Mar 28, 2022

Part of #32651.

We also move cdd_Vrepresentation and cdd_Hrepresentation to Polyhedron_base0.

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: f3c68a5

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33583

@kliem kliem added this to the sage-9.6 milestone Mar 28, 2022
@kliem
Copy link
Contributor Author

kliem commented Mar 28, 2022

Branch: u/gh-kliem/polyhedron_base7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 28, 2022

Commit: 0e74fa5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 28, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

70267aamove integration and volume to base7
0e74fa5a bit of documentation

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 28, 2022

comment:4

With lrslib installed:

sage -t --long --random-seed=30473451679236788317468564983261889666 src/sage/geometry/polyhedron/base7.py
**********************************************************************
File "src/sage/geometry/polyhedron/base7.py", line 310, in sage.geometry.polyhedron.base7.Polyhedron_base7._volume_lrs
Failed example:
    polytopes.hypercube(3)._volume_lrs() # optional - lrslib
Exception raised:
    Traceback (most recent call last):
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.geometry.polyhedron.base7.Polyhedron_base7._volume_lrs[0]>", line 1, in <module>
        polytopes.hypercube(Integer(3))._volume_lrs() # optional - lrslib
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/geometry/polyhedron/base7.py", line 339, in _volume_lrs
        ans = bytes_to_str(ans)
    NameError: name 'bytes_to_str' is not defined

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 28, 2022

Changed commit from 0e74fa5 to c8c3f53

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 28, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c8c3f53move bytes_to_str import

@kliem
Copy link
Contributor Author

kliem commented Mar 28, 2022

comment:6

Thanks for the catch.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 28, 2022

comment:7
sage -t --long --random-seed=321325385952855352170964946242932397043 src/sage/geometry/polyhedron/base7.py
**********************************************************************
File "src/sage/geometry/polyhedron/base7.py", line 311, in sage.geometry.polyhedron.base7.Polyhedron_base7._volume_lrs
Failed example:
    polytopes.hypercube(3)._volume_lrs() # optional - lrslib
Exception raised:
    Traceback (most recent call last):
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.geometry.polyhedron.base7.Polyhedron_base7._volume_lrs[0]>", line 1, in <module>
        polytopes.hypercube(Integer(3))._volume_lrs() # optional - lrslib
      File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/sage/geometry/polyhedron/base7.py", line 349, in _volume_lrs
        volume = QQ(volume)
    NameError: name 'QQ' is not defined

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2022

Changed commit from c8c3f53 to f3c68a5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f3c68a5missing import of QQ

@kliem
Copy link
Contributor Author

kliem commented Mar 29, 2022

comment:9

lrslib works for me now.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 29, 2022

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Mar 30, 2022

comment:11

Thank you.

@vbraun
Copy link
Member

vbraun commented Apr 2, 2022

Changed branch from u/gh-kliem/polyhedron_base7 to f3c68a5

@vbraun vbraun closed this as completed in 4a8c685 Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants