Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed parameter to GF #33348

Closed
roed314 opened this issue Feb 15, 2022 · 4 comments
Closed

Add seed parameter to GF #33348

roed314 opened this issue Feb 15, 2022 · 4 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Feb 15, 2022

For small (p, n), we use Conway polynomials so you get the same finite field across different versions of sage. For large (p, n), the finite field you get in Sage is nondeterministic. This is a minor annoyance, but with the relative extensions we're working on in #28485 together with the changes to randomness in doctesting introduced in #29935 it will become difficult to ever show elements of relative extensions.

I propose adding a seed parameter to GF so that by default the modulus chosen is deterministic. The current behavior could be obtained by setting the seed to None.

Component: finite rings

Branch/Commit: u/roed/finite_field_seeds @ c17c2d8

Issue created by migration from https://trac.sagemath.org/ticket/33348

@roed314 roed314 added this to the sage-9.6 milestone Feb 15, 2022
@roed314
Copy link
Contributor Author

roed314 commented Feb 15, 2022

Branch: u/roed/finite_field_seeds

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4b72e9eMerge branch 'u/roed/finite_field_seeds' of https://github.com/sagemath/sagetrac-mirror into t/33348/finite_field_seeds
c17c2d8Improve defaults, fix a doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 15, 2022

Commit: c17c2d8

@roed314
Copy link
Contributor Author

roed314 commented Feb 15, 2022

comment:3

Looking into this more, I don't think it's necessary for absolute extensions, since the polynomial pari generates is deterministic when the base field is prime. It will be useful for relative extensions, but I'll put this change back into #28485.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants