Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tachyon, primecountpy, libhomfly, m4ri: Fix build errors on Apple Silicon with homebrew #33191

Closed
mkoeppe opened this issue Jan 16, 2022 · 11 comments
Closed

tachyon, primecountpy, libhomfly, m4ri: Fix build errors on Apple Silicon with homebrew #33191

mkoeppe opened this issue Jan 16, 2022 · 11 comments
Labels
c: porting p: blocker / 1 t: enhancement
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 16, 2022

reported in #30592 comment:33

... by extending .homebrew-build-env, as a hotfix.

CC: @dimpase @kiwifb @vbraun

Component: porting

Author: Matthias Koeppe

Branch/Commit: aee855a

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/33191
@mkoeppe mkoeppe added this to the sage-9.5 milestone Jan 16, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 16, 2022

Branch: u/mkoeppe/fix_build_errors_on_apple_silicon_with_homebrew

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 16, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 16, 2022

New commits:

aee855a.homebrew-build-env: Add libpng bdw-gc primesieve dirs to CPATH, LIBRARY_PATH

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 16, 2022

Commit: aee855a

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Fix build errors on Apple Silicon with homebrew tachyon, primecountpy, libhomfly, m4ri: Fix build errors on Apple Silicon with homebrew Jan 16, 2022
@kiwifb
Copy link
Member

kiwifb commented Jan 17, 2022

comment:4

That should work for case at hand. As a hotfix since extending the list that way is not sustainable.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 17, 2022

comment:5

Yes, only a hotfix for 9.5. The correct fix is to make these packages use pkg-config to get the paths for the dependencies

@kiwifb
Copy link
Member

kiwifb commented Jan 17, 2022

comment:6

Let's just get it in.

@kiwifb
Copy link
Member

kiwifb commented Jan 17, 2022

Reviewer: François Bissey

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 17, 2022

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 18, 2022

Changed branch from u/mkoeppe/fix_build_errors_on_apple_silicon_with_homebrew to aee855a

@vbraun vbraun closed this as completed in 290af2b Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting p: blocker / 1 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@kiwifb @vbraun @mkoeppe