Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPython/Jupyter upgrade for python 3.10 support #32930

Closed
mkoeppe opened this issue Nov 25, 2021 · 16 comments
Closed

IPython/Jupyter upgrade for python 3.10 support #32930

mkoeppe opened this issue Nov 25, 2021 · 16 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 25, 2021

All updated packages still support Python 3.7, as needed for the Sage 9.5 series.

CC: @enriqueartal @tornaria @egourgoulhon @kwankyu @orlitzky

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 66c16b1

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/32930

@mkoeppe mkoeppe added this to the sage-9.5 milestone Nov 25, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2021

Last 10 new commits:

73df3fcbuild/pkgs/ipywidgets: Update to 7.6.5
5e144e9build/pkgs/jedi: Update to 0.18.1
6347f98build/pkgs/prompt_toolkit: Update to 3.0.22
28e535dbuild/pkgs/widgetsnbextension: Update to 3.5.2
63078acbuild/pkgs/terminado: Update to 0.12.1
22de5dcbuild/pkgs/notebook: Update to 6.4.6
a0fe18bbuild/pkgs/nbclient: Update to 0.5.4
ef3fc7fbuild/pkgs/jupyter_client: Update to 7.1.0
a593bc9build/pkgs/jupyter_core: Update to 4.9.1
66c16b1build/pkgs/importlib_metadata: Update to 4.8.2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2021

Commit: 66c16b1

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 26, 2021

comment:5

Tests look OK. Ready for review

@slel
Copy link
Member

slel commented Nov 27, 2021

comment:6

Is a similar ticket needed for JupyterLab
(optional package) too?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 28, 2021

comment:7

There's a separate ticket somewhere for that

@slel
Copy link
Member

slel commented Nov 28, 2021

comment:8

Oh, #32069, I see.

@orlitzky
Copy link
Contributor

orlitzky commented Dec 3, 2021

comment:11

I'm testing this along with #31535. I've run

$ EXTRA_CONFIGURE_ARGS="--without-system-python3" tox -e local-direct -- build sagelib-tox-python-sagewheels-nopypi

and I'm seeing doctest failures like

Failed example:
    shell = get_test_shell()
Expected nothing
Got:
    doctest:warning
    ...
   :
    UserWarning: Attempting to work in a virtualenv. If you encounter problems, please install IPython inside the virtualenv.
    Error processing line 1 of /home/mjo/src/sage.git/pkgs/sagemath-standard/.tox/python-sagewheels-nopypi/lib/python3.9/site-packages/_virtualenv.pth:
    <BLANKLINE>
      Traceback (most recent call last):
        File "/home/mjo/src/sage.git/.tox/local-direct/local/lib/python3.9/site.py", line 169, in addpackage
          exec(line)
        File "<string>", line 1, in <module>
      ModuleNotFoundError: No module named '_virtualenv'
    <BLANKLINE>
    Remainder of file ignored

Does that look like a tox issue, or something that changed with ipython?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 3, 2021

comment:12

I think this might be fixed with #32933

@orlitzky
Copy link
Contributor

orlitzky commented Dec 4, 2021

comment:13

Yep, looks like that was it.

@orlitzky
Copy link
Contributor

orlitzky commented Dec 4, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1502165423 to Michael Orlitzky

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 4, 2021

comment:14

Thanks for reviewing!

@vbraun
Copy link
Member

vbraun commented Dec 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants