fix E713 and E714 in matrix, modules, groups

[fchapoton]

about negative comparison using "is not"

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 9c1d6b4

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32766

[fchapoton]

Branch: u/chapoton/32766

[fchapoton]

Commit: ea822d0

[fchapoton]

New commits:

ea822d0

fix E713 and E714 in matrix, groups, modules

[mkoeppe]

comment:2

The failure in src/sage/rings/integer.pyx is not from this ticket.

[mkoeppe]

comment:3

--- a/src/sage/modules/with_basis/morphism.py
+++ b/src/sage/modules/with_basis/morphism.py
@@ -175,11 +175,11 @@ class ModuleMorphism(Morphism):
             sage: TestSuite(phi).run()
         """
         if category is None:
-            if not domain in ModulesWithBasis:
-                raise ValueError("domain(=%s) should be a module with basis"%(codomain))
+            if domain not in ModulesWithBasis:
+                raise ValueError("domain(=%s) should be a module with basis" % (codomain))
             base_ring = domain.base_ring()
 
-            if not hasattr( codomain, 'base_ring' ):
+            if not hasattr(codomain, 'base_ring'):
                 raise ValueError("codomain(=%s) needs to have a base_ring attribute"%(codomain))
             # codomain should be a module over base_ring
             # The natural test would be ``codomains in Modules(base_ring)``

In these changes, could also remove the parentheses around codomain.

Otherwise LGTM, feel free to set to positive_review.

[mkoeppe]

Reviewer: Matthias Koeppe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9c1d6b4

some details

[sagetrac-git]

Changed commit from ea822d0 to 9c1d6b4

[fchapoton]

comment:6

ok, fixed. Thanks

I allow myself to set to positive

[vbraun]

Changed branch from u/chapoton/32766 to 9c1d6b4