Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last fixes for relint linter #32757

Closed
fchapoton opened this issue Oct 24, 2021 · 10 comments
Closed

last fixes for relint linter #32757

fchapoton opened this issue Oct 24, 2021 · 10 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@fchapoton
Copy link
Contributor

namely

  • remove check for sagenb

  • remove last traces of __metaclass__

This should allow this linter to turn green.

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: c2cba32

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32757
@fchapoton fchapoton added this to the sage-9.5 milestone Oct 24, 2021
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32757

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

New commits:

623537clast fixes for relint : remove sagenb check and __metaclass_

@fchapoton
Copy link
Contributor Author

Commit: 623537c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2021

Changed commit from 623537c to c2cba32

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c2cba32one more fix

@fchapoton
Copy link
Contributor Author

comment:3

the last problem in the other linter has been fixed elsewhere

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 25, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 25, 2021

comment:4

LGTM. The failure in src/sage/rings/integer.pyx is not from this ticket.

@vbraun
Copy link
Member

vbraun commented Oct 28, 2021

Changed branch from u/chapoton/32757 to c2cba32

@vbraun vbraun closed this as completed in 50776da Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe