remove obsolete code in EllipticCurveIsogeny.is_normalized()

[yyyyx4]

The EllipticCurveIsogeny.is_normalized() method accepts two optional arguments, via_formal and check_by_pullback, that have been documented as deprecated since #7096 — for over 10 years! — albeit without printing a deprecation warning in the code itself. It might be about time to get rid of them.

The patch removes the obsolete code. According to the discussion below, no deprecation warning seems necessary.

CC: @categorie @JohnCremona

Component: elliptic curves

Keywords: isogeny, deprecation

Author: Lorenz Panny

Branch/Commit: 3a9e585

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/32430

[yyyyx4]

Author: Lorenz Panny

[yyyyx4]

New commits:

cca4acd

EllipticCurveIsogeny.is_normalized: remove obsolete algorithm

[yyyyx4]

Branch: public/remove_obsolete_code_in_EllipticCurveIsogeny_is_normalized

[yyyyx4]

Commit: cca4acd

[fchapoton]

comment:3

Looks good, but maybe we can just get rid of them right now ?

@JohnCremona : John, your opinion ?

Otherwise, you need to doctest the deprecation...

[JohnCremona]

comment:4

I'm sure this is fine. I would say that we do not need to put in the warning after so long, but then I don't use this feature as far as I can remember.

[chriswuthrich]

comment:5

I agree that this can go without the need of a deprecation.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3a9e585

probably no need to warn after >10 years of deprecation

[sagetrac-git]

Changed commit from cca4acd to 3a9e585

[yyyyx4]

comment:7

Thanks everyone for the feedback! Removed the warning.

[fchapoton]

comment:8

let's go

[fchapoton]

Reviewer: Frédéric Chapoton

[vbraun]

Changed branch from public/remove_obsolete_code_in_EllipticCurveIsogeny_is_normalized to 3a9e585