Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of MixedIntegerLinearProgram in sage.graphs.graph - part 1 #32237

Closed
dcoudert opened this issue Jul 19, 2021 · 13 comments
Closed

Fix use of MixedIntegerLinearProgram in sage.graphs.graph - part 1 #32237

dcoudert opened this issue Jul 19, 2021 · 13 comments

Comments

@dcoudert
Copy link
Contributor

Part of #32191 (Meta-ticket: Audit/fix all uses of MixedIntegerLinearProgram in sage.combinat, sage.graphs).

We update the following methods in graph.py and bipartite_graph.py:

  • degree_constrained_subgraph
  • minimum_outdegree_orientation
  • matching
  • has_perfect_matching

Depends on #32197

CC: @mkoeppe @tscrim @dimpase

Component: graph theory

Author: David Coudert

Branch/Commit: b7e9915

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32237

@dcoudert dcoudert added this to the sage-9.4 milestone Jul 19, 2021
@dcoudert
Copy link
Contributor Author

Branch: oublic/graphs/32237_graph_1

@dcoudert
Copy link
Contributor Author

Dependencies: #32197

@dcoudert
Copy link
Contributor Author

Last 10 new commits:

3dca4e9MixedIntegerLinearProgram.get_values: If convert=True, convert real variables from float to base_ring
9ad3fa8MixedIntegerLinearProgram.get_converted_values; subsumed by get_values
f62a777src/sage/numerical/mip.pyx: Remove unused imports
cfd8c7btrac #32197: remove another useless import
cf16293MixedIntegerLinearProgram.get_values: Fix up for tolerance=None
5a74113MixedIntegerLinearProgram._backend_variable_value: Add docstring
aa4eed5MixedIntegerLinearProgram._backend_variable_value*: Add docstrings, examples
00b34aatrac #32197: review commit
db83853trac #32197: another review commit
231e9f8trac #32237: graph part 1

@dcoudert
Copy link
Contributor Author

Changed branch from oublic/graphs/32237_graph_1 to public/graphs/32237_graph_1

@dcoudert
Copy link
Contributor Author

Commit: 231e9f8

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2021

comment:3

LGTM. Green patchbot => positive review

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b7e9915trac #32237: add paramter to method matching in bipartite_graph

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2021

Changed commit from 231e9f8 to b7e9915

@dcoudert

This comment has been minimized.

@dcoudert
Copy link
Contributor Author

comment:5

I forgot to modify method matching in bipartite_graph.py.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 20, 2021

comment:6

I've tested it locally

@vbraun
Copy link
Member

vbraun commented Jul 25, 2021

Changed branch from public/graphs/32237_graph_1 to b7e9915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants