sage.geometry.hyperbolic_space: __matmul__ for composition of isometries

[mkoeppe]

Follow-up from #30244

Depends on #30244

CC: @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/sage_geometry_hyperbolic_space__use_actions_instead_of_overriding___mul______rmul__ @ 32c7d40

Issue created by migration from https://trac.sagemath.org/ticket/32212

[mkoeppe]

Branch: u/mkoeppe/sage_geometry_hyperbolic_space__use_actions_instead_of_overriding___mul______rmul__

[mkoeppe]

Dependencies: #30244

[mkoeppe]

New commits:

1bb878c	HyperbolicIsometry: Split out _composition from `__mul__` so that also @ between isometries works
923ebb7	HyperbolicIsometryPD: Override _composition, not __mul__

[mkoeppe]

Commit: 923ebb7

[sagetrac-git]

Changed commit from 923ebb7 to 32c7d40

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

66206f9	FanMorphism: Define `__matmul__`, not __mul__
3006833	FiniteSetEndoMap*: Define `__matmul__`, delegate to it from __mul__
de14c34	TensorWithIndices: Make `__matmul__` an alias of __mul__
451eb95	Map.__mul__: Add doctest output
348f680	TensorWithIndices: Update doctests
e808163	Merge #30244
305029a	CoercionModel.verify_coercion_maps: Use @ instead of * for composition
1a6671f	PrecomposedAction.__init__: Use @ instead of * for composition
2d8698f	HyperbolicGeodesic*: More @ instead of *
32c7d40	HyperbolicIsometry.__matmul__: Repair composition of isometries from different models

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

comment:6

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

[mkoeppe]

comment:7

needs rebase

[grhkm21]

@mkoeppe What should I do if I want to unblock this ticket? Review it here or {make a new branch on my fork with the commits, rebase, then PR}? (I assume "rebase" means just git merge and fixing conflicts right?)

Also I realised you are the author, but I can help with rebasing.

[mkoeppe]

Yes, please feel free to take over. Preparing a PR is the best way forward.
Whether you use git merge or git rebase to refresh the branch is up to you

[grhkm21]

Will do 👍🏻

I didn’t know git rebase is a thing, oops.