-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some doctests that fail for various random seeds #32188
Comments
Commit: |
comment:3
I've made three review commits: two just re-enable the tests for #32095 and #32185, and the last one tries to do something more useful with that rank example over I have one other question:
That looks suspicious to me. It's looping until... what? Neither Otherwise the rest LGTM. |
Changed branch from u/gh-kliem/fix_various_doctests_failing_on_random_seeds to u/mjo/ticket/32188 |
Changed branch from u/mjo/ticket/32188 to u/gh-kliem/ticket/32188 |
New commits:
|
comment:7
To answer my own question from comment:3, it looks like # We arrive at this point by running
# c = C.random_element(); y = Chan(c); D.decode_to_message(y)
# in a loop until a ZeroDivisionError is thrown.
sage: c
(56, 57, 51, 49, 50, 51, 18, 6, 56, 35, 53, 49, 25, 47, 19, 31, 3, 22, 34, 38, 53, 34, 29, 15, 58, 38, 21, 53, 23, 14, 1, 23, 22, 37, 39, 12, 8, 23, 39, 37)
sage: y
(56, 22, 51, 36, 50, 10, 18, 6, 56, 35, 53, 49, 58, 56, 53, 31, 3, 22, 34, 3, 53, 34, 38, 15, 0, 38, 21, 0, 46, 3, 1, 23, 43, 42, 39, 12, 8, 23, 33, 37)
sage: D.decode_to_message(y)
...
ZeroDivisionError: inverse of Mod(0, 59) does not exist
sage: y = Chan(c)
sage: D.decode_to_message(y)
...
DecodingError: Decoding failed because the number of errors exceeded the decoding radius Regardless... it's doing what it should somehow. |
Reviewer: Michael Orlitzky |
comment:9
Thank you. I had somehow forgotten about your question from comment:3. |
Changed branch from u/gh-kliem/ticket/32188 to |
We fix some doctests or mark them as
# not tested
that were discovered when testing #29935. This should make the review of #29935 easier.All the tests failed for some random seed during
Depends on #32095
Depends on #32185
CC: @orlitzky
Component: doctest framework
Author: Jonathan Kliem
Branch/Commit:
48b8e0b
Reviewer: Michael Orlitzky
Issue created by migration from https://trac.sagemath.org/ticket/32188
The text was updated successfully, but these errors were encountered: