Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0/0 in ore function field #32109

Closed
kliem opened this issue Jul 3, 2021 · 12 comments
Closed

Fix 0/0 in ore function field #32109

kliem opened this issue Jul 3, 2021 · 12 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jul 3, 2021

sage: k.<a> = GF(5^2)
sage: Frob = k.frobenius_endomorphism()
sage: der = k.derivation(a, twist=Frob)
sage: S.<x> = k['x', der]
sage: K = S.fraction_field()
sage: K(0)/K(0)
0

CC: @xcaruso

Component: algebra

Author: Jonathan Kliem

Branch/Commit: 192b564

Reviewer: Markus Wageringel, Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/32109

@kliem kliem added this to the sage-9.4 milestone Jul 3, 2021
@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

Branch: public/32109

@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

Commit: 9e53965

@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

New commits:

9e53965fix 0/0 in ore function field

@mwageringel
Copy link

Reviewer: Markus Wageringel

@mwageringel
Copy link

comment:2

This looks good to me. You can set this to positive if the bot is happy.

@xcaruso
Copy link
Contributor

xcaruso commented Jul 3, 2021

comment:3

I think you need to add the trac ticket number in the doctest, e.g. add the sentence:

    We check that :trac:`32109` is fixed::

before the test.

Otherwise, it looks good.

@xcaruso
Copy link
Contributor

xcaruso commented Jul 3, 2021

Changed reviewer from Markus Wageringel to Markus Wageringel, Xavier Caruso

@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

comment:4

I think this is usually done for bugs that include a discussion, which is not the case here. But sure.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

192b564add ticked number to test

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2021

Changed commit from 9e53965 to 192b564

@xcaruso
Copy link
Contributor

xcaruso commented Jul 3, 2021

comment:6

Thanks.

@vbraun
Copy link
Member

vbraun commented Jul 23, 2021

Changed branch from public/32109 to 192b564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants