-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use libgiac instead of giac for integration #31873
Comments
Changed keywords from none to giac |
Author: Markus Wageringel |
Commit: |
Branch: u/gh-mwageringel/31873 |
Changed keywords from giac to giac, integration |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Matthias Koeppe |
comment:5
LGTM |
comment:6
Thanks. |
comment:7
test failures
|
comment:9
I have fixed the doctests. Now this passes ptestlong again. Also, this does not conflict with #32275. |
Changed branch from u/gh-mwageringel/31873 to |
Now that giacpy_sage has been included into Sage by #29171, we can use it for integration instead of the Pexpect interface. This ticket adds a
libgiac_integrator
which replaces thegiac_integrator
in the default integrator (which uses Maxima, Giac, and Sympy).This will resolve issues like #28913 or this ask-sage question where the Pexpect output cannot be parsed by Sage because Giac prints warning messages to the output.
The
libgiac_integrator
behaves slightly different than the Pexpect-based integrator, in that warning messages issued by Giac are not stripped away anymore.These messages are generally useful in interactive use. For doctests, the current branch adjusts most of the tests so that they do not depend on the presence of these messages.
Due to the problem at #31655, the first doctest in a file that uses libgiac results in some additional messages, but again the tests are written so that this does not matter. If that ticket is resolved, the second commit could be mostly reverted, but this is not strictly necessary. With the default integrator, these Giac loading messages will appear on the first integral that Maxima cannot solve.
Part of meta-ticket #16688.
CC: @slel
Component: interfaces
Keywords: giac, integration
Author: Markus Wageringel
Branch/Commit:
bb15f0f
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/31873
The text was updated successfully, but these errors were encountered: