-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove clash of tdlib/ with tdlib.pyx in src/sage/graphs/graph_decompositions #31389
Comments
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
comment:3
I tried it and it looks good to me, but may be I have not tested it enough. Should I do something special apart testing that doctests pass ? New commits:
|
Commit: |
comment:4
I think it's a pretty straightforward change, I do not expect problems. |
Reviewer: David Coudert |
comment:5
So then. |
comment:6
Thank you! |
Changed branch from u/mkoeppe/remove_clash_of_tdlib__with_tdlib_pyx_in__src_sage_graphs_graph_decompositions to |
In an editable install of sagelib (#31377), the
tdlib
subdirectory is considered as a namespace package directory, shadowing thesage.graphs.graph_decompositions.tdlib
module, causing the failures reported on that ticket.We fix this by moving the file
tdlib/sage_tdlib.cpp
(the only file in that subdirectory) one level higher.CC: @dcoudert @dimpase @tobiasdiez
Component: graph theory
Author: Matthias Koeppe
Branch/Commit:
19ca17a
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/31389
The text was updated successfully, but these errors were encountered: