Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clash of tdlib/ with tdlib.pyx in src/sage/graphs/graph_decompositions #31389

Closed
mkoeppe opened this issue Feb 12, 2021 · 10 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2021

In an editable install of sagelib (#31377), the tdlib subdirectory is considered as a namespace package directory, shadowing the sage.graphs.graph_decompositions.tdlib module, causing the failures reported on that ticket.

We fix this by moving the file tdlib/sage_tdlib.cpp (the only file in that subdirectory) one level higher.

CC: @dcoudert @dimpase @tobiasdiez

Component: graph theory

Author: Matthias Koeppe

Branch/Commit: 19ca17a

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/31389

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 12, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title Remove clash of tdlib/ with tdlib.pyx in /src/sage/graphs/graph_decompositions Remove clash of tdlib/ with tdlib.pyx in src/sage/graphs/graph_decompositions Feb 12, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2021

@dcoudert
Copy link
Contributor

comment:3

I tried it and it looks good to me, but may be I have not tested it enough. Should I do something special apart testing that doctests pass ?


New commits:

19ca17asrc/sage/graphs/graph_decompositions/tdlib/sage_tdlib.cpp: Move one directory level higher

@dcoudert
Copy link
Contributor

Commit: 19ca17a

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2021

comment:4

I think it's a pretty straightforward change, I do not expect problems.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:5

So then.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2021

comment:6

Thank you!

@vbraun
Copy link
Member

vbraun commented Mar 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants