Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build-local, make build-venv #31362

Closed
mkoeppe opened this issue Feb 8, 2021 · 18 comments
Closed

make build-local, make build-venv #31362

mkoeppe opened this issue Feb 8, 2021 · 18 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 8, 2021

The new make target build-local will build all non-Python packages that make build builds.

make build-venv will build all Python packages that make build builds.

Preparation for #30896, #30371 and related to #30913.

Depends on #30912

CC: @tobiasdiez @jhpalmieri @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 61f6ba6

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/31362

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 8, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d7dc9a2build/make/Makefile.in: New targets all-sage-local, all-sage-venv

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 8, 2021

Commit: d7dc9a2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 8, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

2a91862build/pkgs/sagelib/src/README.rst: Add some text
6432727Merge tag '9.3.beta2' into t/30912/sagelib__update_metadata_for_pypi_deployment
4a693f2Move build/pkgs/sagelib/src/setup.cfg to SAGE_ROOT/src, replace by symlink
ea182d7Copy changes from build/pkgs/sagelib/src to src
a1a10b9src/VERSION.txt: New
5697335src/setup.cfg: Add license_file=LICENSE.txt
deb9eb3Merge tag '9.3.beta3' into t/30912/sagelib__update_metadata_for_pypi_deployment
7ad4c0eMerge tag '9.3.beta4' into t/30912/sagelib__update_metadata_for_pypi_deployment
27b589bMerge branch 't/30912/sagelib__update_metadata_for_pypi_deployment' into t/31362/make_all_sage_local__make_all_sage_venv
8796008Put pynac into SAGE_LOCAL, sagelib into SAGE_VENV

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 8, 2021

Changed commit from d7dc9a2 to 8796008

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2021

Dependencies: #30912

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2021

Changed commit from 8796008 to d6831b1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d6831b1build/make/Makefile.in: Add all-build-local, all-build-venv, which include dependency on toolchain

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

61f6ba6Makefile: Add top-level targets build-local, build-venv

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2021

Changed commit from d6831b1 to 61f6ba6

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title make all-sage-local, make all-sage-venv make build-local, make build-venv Feb 9, 2021
@mkoeppe

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:11

This does what it's supposed to. Let's merge it. If there are any bugs, they should be revealed in followup tickets.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 17, 2021

comment:12

Thank you!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/mkoeppe/make_all_sage_local__make_all_sage_venv to 61f6ba6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants